This repository was archived by the owner on Jul 29, 2024. It is now read-only.
README.md to use correct runtime property key #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct name in context: https://github.com/aws-samples/amazon-kinesis-data-analytics-flink-starter-kit/blob/7e70b7225b4ab76872818f3979ec48246fb20937/src/main/java/com/amazonaws/kda/flink/starterkit/SessionProcessor.java#L118 This breaks the app at runtime if set incorrectly.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Updated runtime property name in readme to match name in code.
Correct name in context:
amazon-kinesis-data-analytics-flink-starter-kit/src/main/java/com/amazonaws/kda/flink/starterkit/SessionProcessor.java
Line 118 in 7e70b72
If set incorrectly, this breaks the app at runtime with the following error, making the sample app unusable:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.