Do not create SageMaker and StepFunctions endpoints when not needed #511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rob-Powell
reviewed
Jul 9, 2024
lib/shared/index.ts
Outdated
| service: ec2.InterfaceVpcEndpointAwsService.SAGEMAKER_RUNTIME, | ||
| open: true, | ||
| }); | ||
| if (props.config.llms.sagemaker.length > 0){ |
There was a problem hiding this comment.
does this account for the fact that the re-ranker endpoint is always running when rag is enabled? even if no specific sagemaker models are chosen
There was a problem hiding this comment.
Yes, that should be the reason
charles-marion
requested changes
Aug 27, 2024
| service: ec2.InterfaceVpcEndpointAwsService.SAGEMAKER_RUNTIME, | ||
| open: true, | ||
| }); | ||
| if (props.config.llms.sagemaker.length > 0) { |
There was a problem hiding this comment.
Suggested change
| if (props.config.llms.sagemaker.length > 0) { | |
| if (props.config.llms.sagemaker.length > 0 || props.config.rag.enabled) { |
At this time, If rag is enabled, it will automatically create a sagemaker endpoint for embedding/cross encoding regardless of the config. (unless I am mistaken?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: N/A
Description of changes:
Don't create the Sagemaker endpoint if sagemaker is not enabled in config.
Don't create the StepFunctions endpoint if RAG is not enabled in config.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.