fix: add custom attribute to cognito for OIDC and SAML deployments #673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charles-marion
approved these changes
Jul 31, 2025
| @@ -34,6 +34,9 @@ export class Authentication extends Construct { | |||
| signInAliases: { | |||
| email: true, | |||
| }, | |||
| customAttributes: { | |||
There was a problem hiding this comment.
I believe this is only used when federation is used. I would conditionally set this.
To my knowledge the attribute was set without this cdk property. (but I only tested once a while back)
Also note this other change: https://github.com/aws-samples/aws-genai-llm-chatbot/pull/672/files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description
This change adds a custom attribute configuration to the Cognito User Pool to support OIDC (OpenID Connect) and SAML authentication deployments. This enhancement improves the authentication flow by ensuring proper attribute mapping for federated identity providers.
Files Changed
• tests/snapshots/cdk-app.test.ts.snap
• tests/authentication/snapshots/autentication-construct.test.ts.snap
• tests/chatbot-api/snapshots/chatbot-api-construct.test.ts.snap
Impact
• Enables proper attribute handling for federated authentication scenarios
• Maintains backward compatibility with existing authentication flows
• Updates test snapshots to ensure CI/CD pipeline continues to pass
Testing
• All existing tests updated with new snapshots
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.