Skip to content

Conversation

@KyopoCanuck
Copy link
Contributor

When resources have long names the ability to check for known tokens in the resulting generated names becomes unreliable. This updates the checks for nested stacks to:

  • Collect nested stack physical ID's by searching through every stacks resource map for CloudFormation stack resources
  • Filter the list of all stacks to down to nested stacks by checking the stack name against the list of nested stack physical ID's, i.e. physical ID contains string :stack/STACK_NAME/

--

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@KyopoCanuck KyopoCanuck force-pushed the fix/nested-stack-lookup branch from 3744444 to ad46b91 Compare February 12, 2025 18:04
@rycerrat rycerrat self-requested a review February 12, 2025 21:13
Copy link
Contributor

@rycerrat rycerrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rycerrat rycerrat merged commit 5dd1c64 into aws-samples:main Feb 12, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants