-
Notifications
You must be signed in to change notification settings - Fork 152
RLVR Recipe in added post-training section #891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! but let's not add submodule.
3.test_cases/post-training/rlvr/observability/otel-collector-config-backup.yaml
Outdated
Show resolved
Hide resolved
|
The directory structure under test case is formatted as |
|
lmk - thanks keita! |
|
KeitaW
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some additional minor comments.
KeitaW
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've stopped blocking this PR from merging, but please consider addressing the remaining comments before merging.
|
Thanks again for the contribution! |
|
Nice! |
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.