Skip to content

Deploy error fix #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Deploy error fix #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6569fd0
fix: correct AWS::REGION to AWS::Region in template
PG-practice May 25, 2025
8dfbf8e
fix: resolve pipeline execution errors
PG-practice May 25, 2025
880395c
chore: remove unused file
PG-practice May 25, 2025
0797515
chore: remove hardcode of ECR region
PG-practice May 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 0 additions & 61 deletions iac/app/templates/codedeploy-deployment.yaml
View file
Open in desktop

This file was deleted.

7 changes: 3 additions & 4 deletions iac/pipeline/code-pipeline.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ Resources:
Image: aws/codebuild/standard:3.0
EnvironmentVariables:
- Name: AWS_DEFAULT_REGION
Value: !Ref "AWS::REGION"
Value: !Ref "AWS::Region"
- Name: TEMPLATE_BUCKET
Value: !Ref rCodePipelineArtifactBucket
TimeoutInMinutes: 60
Expand Down Expand Up @@ -341,7 +341,7 @@ Resources:
PrivilegedMode: true
EnvironmentVariables:
- Name: AWS_DEFAULT_REGION
Value: !Ref "AWS::REGION"
Value: !Ref "AWS::Region"
- Name: S3_BUCKET
Value: !Ref rCodePipelineArtifactBucket
- Name: REPOSITORY_URI
Expand Down Expand Up @@ -385,7 +385,7 @@ Resources:
# Create appspec.yml for CodeDeploy deployment
- python iac/code-deploy/scripts/update-appspec.py --taskArn ${TASKDEF_ARN} --hooksLambdaArn ${HOOKS_LAMBDA_ARN} --inputAppSpecFile 'iac/code-deploy/appspec.yml' --outputAppSpecFile '/tmp/appspec.yml'
# Create taskdefinition for CodeDeploy deployment
- aws ecs describe-task-definition --task-definition ${TASKDEF_ARN} --region ${AWS_REGION} --query taskDefinition >> taskdef.json
- aws ecs describe-task-definition --task-definition ${TASKDEF_ARN} --region ${AWS_REGION} --query taskDefinition >> /tmp/taskdef.json
artifacts:
files:
- /tmp/appspec.yml
Expand Down Expand Up @@ -474,7 +474,6 @@ Resources:
Capabilities: CAPABILITY_NAMED_IAM
RoleArn: !GetAtt rCloudFormationServiceRole.Arn
StackName: !Sub ${pApplicationName}-infra-stack
OutputFileName: InfraStackOutput.json
TemplateConfiguration: PackagedCFNOutput::iac/app/params/ecs-bg-params.json
TemplatePath: PackagedCFNOutput::iac/app/ecs-bg-packaged.yaml
ParameterOverrides: |
Expand Down
2 changes: 1 addition & 1 deletion iac/pipeline/codebuild/buildspec-container.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ phases:
pre_build:
commands:
- echo Logging in to Amazon ECR...
- aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin $REPOSITORY_URI
- aws ecr get-login-password --region $AWS_DEFAULT_REGION | docker login --username AWS --password-stdin $REPOSITORY_URI
- IMAGE_TAG=$(echo $CODEBUILD_SOURCE_VERSION |cut -d/ -f4 |cut -d'.' -f1)
- TIMESTAMP=$(date +%Y%m%d%H%M)
- echo $IMAGE_TAG
Expand Down