Add branding customization support for logo and title #1339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbrand
reviewed
Oct 30, 2025
| <img src={customLogoUrl} alt={title || 'Logo'} className="mr-5 size-20" /> | ||
| ) : ( | ||
| <AwsIcon className="mr-5 size-20" /> | ||
| ); |
There was a problem hiding this comment.
もう少しシンプルかつメモ化して実装したほうが良さそうな気がしました。
customLogoUrl を state で管理する必要がないと思うので、以下のような感じ。
const displayLogo = useMemo(() => {
// logoPath があったら <img/> を返し、なければ <AwsIcon/> を返す
}, [logoPath]);
| const logoPath = import.meta.env.VITE_APP_BRANDING_LOGO_PATH; | ||
| const title = import.meta.env.VITE_APP_BRANDING_TITLE; | ||
|
|
||
| console.log('Branding config:', { logoPath, title }); |
| const { enabled } = useUseCases(); | ||
| const { setIsShow, init } = useInterUseCases(); | ||
| const { t } = useTranslation(); | ||
| const { logoPath, title } = useBranding(); |
There was a problem hiding this comment.
これビルド時に組み込まれている環境変数から読み込んでいるだけの定数なので、hook 化するか微妙ですね。ragEnabled などと同様に、上部で定数として読み込んでも良い気がしました。なにか今後の展望的に hook 化したほうが良さそう的なことありますか？
There was a problem hiding this comment.
ありがとうございます。
無理やり理由つけるなら、将来的な話だと動的に変えたい、ってくらいですが、今そんな話は特にないので、環境変数を直接読むようにします。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Add support for customizing the logo and title displayed on the landing page through a configuration file.
Checklist
npm run cdk:testand if there are snapshot differences, executenpm run cdk:test:update-snapshotto update snapshotsRelated Issues
#1338