Skip to content

Conversation

alexgromero
Copy link
Contributor

Issue #, if available:

Description of changes:
Fixes flaky integration tests that were failing with BucketAlreadyExists errors when run concurrently.

Changes:

  • Import random_bucket_name from awscli.testutils
  • Replace manual bucket name generation with random_bucket_name(prefix) calls

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.33%. Comparing base (68039fa) to head (6e30318).
⚠️ Report is 311 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9778      +/-   ##
===========================================
- Coverage    93.40%   93.33%   -0.07%     
===========================================
  Files          211      209       -2     
  Lines        17012    16807     -205     
===========================================
- Hits         15890    15687     -203     
+ Misses        1122     1120       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alexgromero alexgromero requested a review from Copilot October 10, 2025 20:51
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes flaky integration tests that were experiencing BucketAlreadyExists errors when run concurrently by replacing manual bucket name generation with a more robust utility function.

  • Import random_bucket_name utility from awscli.testutils
  • Replace manual bucket name generation logic with random_bucket_name(prefix) calls
  • Remove unused random import

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@alexgromero alexgromero requested a review from a team October 10, 2025 20:52
Copy link
Contributor

@AndrewAsseily AndrewAsseily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexgromero alexgromero merged commit 1ef329d into aws:develop Oct 20, 2025
40 checks passed
@alexgromero alexgromero deleted the fix/flaky-integration-tests branch October 20, 2025 14:34
aws-sdk-python-automation added a commit that referenced this pull request Oct 21, 2025
* release-1.42.56:
  Bumping version to 1.42.56
  Update changelog based on model updates
  Fix flaky S3 bucket name generation in integration tests (#9778)
  Add 'wire' as a valid value for cli_timestamp_format. (#9800)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants