Skip to content

Conversation

@trivikr
Copy link
Member

@trivikr trivikr commented Nov 25, 2024

Issue

https://devblogs.microsoft.com/typescript/announcing-typescript-5-7/#path-rewriting-for-relative-paths

Description

Uses node --experimental-strip-types to run TypeScript code and remove tsx

Testing

CI


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@changeset-bot
Copy link

changeset-bot bot commented Nov 25, 2024

🦋 Changeset detected

Latest commit: d8d7ad2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
aws-sdk-js-codemod Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@socket-security
Copy link

socket-security bot commented Nov 25, 2024

@trivikr
Copy link
Member Author

trivikr commented Nov 25, 2024

This was experimental change to check if it's possible

$ node --run generate:tests
(node:25590) [MODULE_TYPELESS_PACKAGE_JSON] Warning: Module type of file:///Users/trivikram/workspace/aws-sdk-js-codemod/scripts/generateNewClientTests/index.ts is not specified and it doesn't parse as CommonJS.
Reparsing as ES module because module syntax was detected. This incurs a performance overhead.
To eliminate this warning, add "type": "module" to /Users/trivikram/workspace/aws-sdk-js-codemod/package.json.
(Use `node --trace-warnings ...` to show where the warning was created)

Not planning to push since the module should be changed to ESM to remove this warning.
And the extension had to be added to all imports.

@trivikr
Copy link
Member Author

trivikr commented Jun 16, 2025

This PR can be revisited when --strip-types is unflagged for Node.js 22.x in nodejs/node#57298, or we switch to using Node.js 24.x in development when it goes LTS in October 2025.

@trivikr
Copy link
Member Author

trivikr commented Jun 18, 2025

--strip-types is likely getting stable in Node.js 22.x as the last blocker from ecosystem is fixed

https://bsky.app/profile/robpalmer.bsky.social/post/3lrunlxiqu22b

@trivikr trivikr force-pushed the allowImportingTsExtensions branch from 2377271 to d8d7ad2 Compare September 9, 2025 18:30
@socket-security
Copy link

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn Critical
vitest@2.0.5 has a Critical CVE.

CVE: GHSA-9crc-q9x8-hgqq Vitest allows Remote Code Execution when accessing a malicious website while Vitest API server is listening (CRITICAL)

Affected versions: >= 1.0.0 < 1.6.1; >= 2.0.0 < 2.1.9; >= 3.0.0 < 3.0.5; <= 0.0.125

Patched version: 2.1.9

From: package-lock.jsonnpm/vitest@2.0.5

ℹ Read more on: This package | This alert | What is a critical CVE?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/vitest@2.0.5. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@trivikr
Copy link
Member Author

trivikr commented Sep 9, 2025

Closing as this was experimental PR, and not worth the change in 150+ files

@trivikr trivikr closed this Sep 9, 2025
@trivikr trivikr deleted the allowImportingTsExtensions branch September 9, 2025 18:35
@github-actions
Copy link
Contributor

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant