-
Notifications
You must be signed in to change notification settings - Fork 11
chore: use node --experimental-strip-types and remove tsx #974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: d8d7ad2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
This was experimental change to check if it's possible $ node --run generate:tests
(node:25590) [MODULE_TYPELESS_PACKAGE_JSON] Warning: Module type of file:///Users/trivikram/workspace/aws-sdk-js-codemod/scripts/generateNewClientTests/index.ts is not specified and it doesn't parse as CommonJS.
Reparsing as ES module because module syntax was detected. This incurs a performance overhead.
To eliminate this warning, add "type": "module" to /Users/trivikram/workspace/aws-sdk-js-codemod/package.json.
(Use `node --trace-warnings ...` to show where the warning was created)Not planning to push since the module should be changed to ESM to remove this warning. |
|
This PR can be revisited when |
|
https://bsky.app/profile/robpalmer.bsky.social/post/3lrunlxiqu22b |
2377271 to
d8d7ad2
Compare
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
|
Closing as this was experimental PR, and not worth the change in 150+ files |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Issue
https://devblogs.microsoft.com/typescript/announcing-typescript-5-7/#path-rewriting-for-relative-paths
Description
Uses node
--experimental-strip-typesto run TypeScript code and remove tsxTesting
CI
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.