Will now accept .yml files and checks the end of the filename #432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hould be fine with files like yaml.json now
DavidJSykes
requested review from
MynockSpit,
etsung-aws,
jiyou95 and
skylarbemus
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue #430
Will now accept uploads of .yml files and work correctly with files named like yaml.json
*Description of changes:
Checks the end of the filename for the extension instead of anywhere in the filename (should avoid cases like a file being name yaml.json)
Accepts files ending with .yml correctly as the uploading box indicates it should.
Just a quick fix, there could probably be some better notification for the user on error too but this should at least do what the prompt says it will now.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.