-
Notifications
You must be signed in to change notification settings - Fork 49
Expose cipher suite TLSv1_2_2025_07 #684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
xiazhvera
wants to merge
14
commits into
main
Choose a base branch
from
cipher_suites
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+20
−0
Open
Changes from 9 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
d0d0213
expose cipher suite TLSv1_2_2025_07
xiazhvera 3523a85
update cipher suit test
xiazhvera dabad26
validate the s2n policy on linux only
xiazhvera 85e8663
add validation for setting cipher suite
xiazhvera 552d71a
update test
xiazhvera e5bbe2d
update lint
xiazhvera 4b072e1
test with fixed aws-c-io
xiazhvera 01b4d30
Merge branch 'main' of https://github.com/awslabs/aws-crt-python into…
xiazhvera 91b7925
update aws-c-io to v0.22.1
xiazhvera 9865fb6
update unit test to test TlsCipherPref.TLSv1_2_2025_07
xiazhvera e70b491
remove unused import
xiazhvera 6771778
Merge branch 'main' into cipher_suites
xiazhvera 7a34aa6
Merge branch 'main' of https://github.com/awslabs/aws-crt-python into…
xiazhvera dcef5d9
improve comments
xiazhvera File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule aws-c-io
updated
3 files
+2 −2 | source/darwin/secure_transport_tls_channel_handler.c | |
+2 −0 | tests/CMakeLists.txt | |
+27 −0 | tests/tls_handler_test.c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Debatable: While the
does not include CBC cipher suites
part is true, and that's what we originally requested from s2n, there are more differences. See aws/s2n-tls#5375When I added the policy to c-io, I used abstract
tightened security
, but now thinking more about it, maybe we should give details on what this preference provides, something like the following: