-
-
Notifications
You must be signed in to change notification settings - Fork 355
Introduce loading parameters as key value store #1495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MatejNedic
wants to merge
1
commit into
awspring:main
Choose a base branch
from
MatejNedic:parameter-store-key-value-resolvement
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,8 +16,11 @@ | |
| package io.awspring.cloud.parameterstore; | ||
|
|
||
| import io.awspring.cloud.core.config.AwsPropertySource; | ||
| import java.io.InputStream; | ||
| import java.util.Arrays; | ||
| import java.util.LinkedHashMap; | ||
| import java.util.Map; | ||
| import java.util.Properties; | ||
| import org.apache.commons.logging.Log; | ||
| import org.apache.commons.logging.LogFactory; | ||
| import org.springframework.lang.Nullable; | ||
|
|
@@ -41,6 +44,8 @@ public class ParameterStorePropertySource extends AwsPropertySource<ParameterSto | |
| // ParameterStoreConfigDataLoader | ||
| private static Log LOG = LogFactory.getLog(ParameterStorePropertySource.class); | ||
| private static final String PREFIX_PART = "?prefix="; | ||
|
|
||
| private static final String PREFIX_PROPERTIES_LOAD = "?properties"; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is that a notation you came up with or other Spring projects follow it too? |
||
| private final String context; | ||
|
|
||
| private final String parameterPath; | ||
|
|
@@ -52,6 +57,8 @@ public class ParameterStorePropertySource extends AwsPropertySource<ParameterSto | |
| @Nullable | ||
| private final String prefix; | ||
|
|
||
| private Boolean propertiesType = false; | ||
|
|
||
| private final Map<String, Object> properties = new LinkedHashMap<>(); | ||
|
|
||
| public ParameterStorePropertySource(String context, SsmClient ssmClient) { | ||
|
|
@@ -87,11 +94,20 @@ public Object getProperty(String name) { | |
| private void getParameters(GetParametersByPathRequest paramsRequest) { | ||
| GetParametersByPathResponse paramsResult = this.source.getParametersByPath(paramsRequest); | ||
| for (Parameter parameter : paramsResult.parameters()) { | ||
| String key = parameter.name().replace(this.parameterPath, "").replace('/', '.').replaceAll("_(\\d)_", | ||
| "[$1]"); | ||
| LOG.debug("Populating property retrieved from AWS Parameter Store: " + key); | ||
| String propertyKey = prefix != null ? prefix + key : key; | ||
| this.properties.put(propertyKey, parameter.value()); | ||
| if (propertiesType) { | ||
| Arrays.stream(parameter.value().split("\\n")).map(line -> line.split("=", 2)).forEach(keyValue -> { | ||
| if (keyValue.length == 2) { | ||
| this.properties.put(keyValue[0].trim(), keyValue[1].trim()); | ||
| } | ||
| }); | ||
| } | ||
| else { | ||
| String key = parameter.name().replace(this.parameterPath, "").replace('/', '.').replaceAll("_(\\d)_", | ||
| "[$1]"); | ||
| LOG.debug("Populating property retrieved from AWS Parameter Store: " + key); | ||
| String propertyKey = prefix != null ? prefix + key : key; | ||
| this.properties.put(propertyKey, parameter.value()); | ||
| } | ||
| } | ||
| if (paramsResult.nextToken() != null) { | ||
| getParameters(paramsRequest.toBuilder().nextToken(paramsResult.nextToken()).build()); | ||
|
|
@@ -112,20 +128,36 @@ String getParameterPath() { | |
| } | ||
|
|
||
| @Nullable | ||
| private static String resolvePrefix(String context) { | ||
| private String resolvePrefix(String context) { | ||
| int prefixIndex = context.indexOf(PREFIX_PART); | ||
| if (prefixIndex != -1) { | ||
| return context.substring(prefixIndex + PREFIX_PART.length()); | ||
| } | ||
| return null; | ||
| } | ||
|
|
||
| private static String resolveParameterPath(String context) { | ||
| private String resolveParameterPath(String context) { | ||
| int prefixIndex = context.indexOf(PREFIX_PART); | ||
| if (prefixIndex != -1) { | ||
| return context.substring(0, prefixIndex); | ||
| } | ||
| prefixIndex = context.indexOf(PREFIX_PROPERTIES_LOAD); | ||
| if (prefixIndex != -1) { | ||
| this.propertiesType = true; | ||
| return context.substring(0, prefixIndex); | ||
| } | ||
| return context; | ||
| } | ||
|
|
||
| private Properties readProperties(InputStream inputStream) { | ||
| Properties properties = new Properties(); | ||
| try (InputStream in = inputStream) { | ||
| properties.load(in); | ||
| } | ||
| catch (Exception e) { | ||
| throw new IllegalStateException("Cannot load environment", e); | ||
| } | ||
| return properties; | ||
| } | ||
|
|
||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can use different example properties to not confuse readers that it has something to do with Spring Cloud AWS region and endpoint configuration?