Skip to content

fix codestyle and add enabled hook list for performance improvement #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2025
Merged

fix codestyle and add enabled hook list for performance improvement #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/LS_loader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

void AddSC_LearnAllSpells();

void Addmod_learn_spellsScripts() {
void Addmod_learn_spellsScripts()
{
AddSC_LearnAllSpells();
}
22 changes: 11 additions & 11 deletions src/mod_learnspells.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,21 +9,23 @@
class LearnSpellsOnLevelUp : public PlayerScript
{
public:
LearnSpellsOnLevelUp() : PlayerScript("LearnSpellsOnLevelUp") { }
LearnSpellsOnLevelUp() : PlayerScript("LearnSpellsOnLevelUp", {
PLAYERHOOK_ON_FIRST_LOGIN,
PLAYERHOOK_ON_LEVEL_CHANGED
}) { }

void OnPlayerFirstLogin(Player* player) override
{
if (sConfigMgr->GetOption<bool>("LearnSpells.OnFirstLogin", 0))
{
LearnSpellsForNewLevel(player, 1);

if (player->getClass() == CLASS_SHAMAN)
{
player->AddItem(5175, 1); // Earth Totem
player->AddItem(5176, 1); // Fire Totem
player->AddItem(5177, 1); // Water Totem
player->AddItem(5178, 1); // Air Totem
}
if (player->getClass() == CLASS_SHAMAN)
{
player->AddItem(5175, 1); // Earth Totem
player->AddItem(5176, 1); // Fire Totem
player->AddItem(5177, 1); // Water Totem
player->AddItem(5178, 1); // Air Totem
}
}

void OnPlayerLevelChanged(Player* player, uint8 oldLevel) override
Expand Down Expand Up @@ -480,9 +482,7 @@ class LearnSpellsOnLevelUp : public PlayerScript
for (auto const& spell : additionalSpellsToTeach)
{
if (!(player->HasSpell(spell.spellId)) && (spell.faction == TeamId::TEAM_NEUTRAL || spell.faction == player->GetTeamId()))
{
player->learnSpell(spell.spellId);
}
}
}
}
Expand Down