Skip to content

Conversation

jeremy-babylonlabs
Copy link
Contributor

No description provided.

@jeremy-babylonlabs jeremy-babylonlabs marked this pull request as ready for review October 12, 2025 19:27
@Copilot Copilot AI review requested due to automatic review settings October 12, 2025 19:27
@jeremy-babylonlabs jeremy-babylonlabs changed the base branch from main to feat/vault-layout-skeleton October 12, 2025 19:28
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a complete vault deposit flow feature for the application, adding new UI components and infrastructure for depositing BTC into vault providers.

  • Adds a vault deposit modal system with multi-step flow (form, signing, success)
  • Creates reusable UI components for vault functionality (stats, deposits, markets overview)
  • Enhances core UI library with new components (Tabs, Step, ProviderCard, ResponsiveDialog)

Reviewed Changes

Copilot reviewed 27 out of 37 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
services/simple-staking/src/ui/common/components/Tabs/index.ts Re-exports Tabs from core-ui package
services/simple-staking/src/ui/common/components/Nav/MobileNavOverlay.tsx Adds vault navigation with feature flag
services/simple-staking/src/ui/common/components/Header/Header.tsx Adds vault navigation to desktop header
routes/vault/src/* New vault route package with complete deposit flow implementation
packages/babylon-core-ui/src/* Enhanced core UI with new components and updated existing ones

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +30 to +33
amount: _amount,
btcConnector: _btcConnector,
btcAddress: _btcAddress,
depositorEthAddress: _depositorEthAddress,
Copy link

Copilot AI Oct 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These parameters are prefixed with underscore to indicate they're unused, but they remain in the function signature. Consider removing them entirely or adding a TODO comment explaining when they'll be implemented.

Suggested change
amount: _amount,
btcConnector: _btcConnector,
btcAddress: _btcAddress,
depositorEthAddress: _depositorEthAddress,

Copilot uses AI. Check for mistakes.

currencyName,
placeholder = "Enter Amount",
subtitle,
subtitle: _subtitle,
Copy link

Copilot AI Oct 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The subtitle parameter is renamed to _subtitle but never used. Since this is a breaking change to the component interface, consider removing it entirely or documenting why it's being kept.

Copilot uses AI. Check for mistakes.

Comment on lines +32 to +34
// Helper function to convert satoshis to BTC
const satoshiToBtc = (satoshi: number): number => {
return satoshi / 100000000;
Copy link

Copilot AI Oct 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The magic number 100000000 should be defined as a named constant (e.g., SATOSHIS_PER_BTC) to improve readability and maintainability.

Suggested change
// Helper function to convert satoshis to BTC
const satoshiToBtc = (satoshi: number): number => {
return satoshi / 100000000;
// Number of satoshis in one BTC
const SATOSHIS_PER_BTC = 100000000;
// Helper function to convert satoshis to BTC
const satoshiToBtc = (satoshi: number): number => {
return satoshi / SATOSHIS_PER_BTC;

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant