-
Notifications
You must be signed in to change notification settings - Fork 3
feat: deposit flow #340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feat/vault-layout-skeleton
Are you sure you want to change the base?
feat: deposit flow #340
Conversation
1ebc8cb
to
530571f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements a complete vault deposit flow feature for the application, adding new UI components and infrastructure for depositing BTC into vault providers.
- Adds a vault deposit modal system with multi-step flow (form, signing, success)
- Creates reusable UI components for vault functionality (stats, deposits, markets overview)
- Enhances core UI library with new components (Tabs, Step, ProviderCard, ResponsiveDialog)
Reviewed Changes
Copilot reviewed 27 out of 37 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
services/simple-staking/src/ui/common/components/Tabs/index.ts | Re-exports Tabs from core-ui package |
services/simple-staking/src/ui/common/components/Nav/MobileNavOverlay.tsx | Adds vault navigation with feature flag |
services/simple-staking/src/ui/common/components/Header/Header.tsx | Adds vault navigation to desktop header |
routes/vault/src/* | New vault route package with complete deposit flow implementation |
packages/babylon-core-ui/src/* | Enhanced core UI with new components and updated existing ones |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
amount: _amount, | ||
btcConnector: _btcConnector, | ||
btcAddress: _btcAddress, | ||
depositorEthAddress: _depositorEthAddress, |
Copilot
AI
Oct 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These parameters are prefixed with underscore to indicate they're unused, but they remain in the function signature. Consider removing them entirely or adding a TODO comment explaining when they'll be implemented.
amount: _amount, | |
btcConnector: _btcConnector, | |
btcAddress: _btcAddress, | |
depositorEthAddress: _depositorEthAddress, |
Copilot uses AI. Check for mistakes.
currencyName, | ||
placeholder = "Enter Amount", | ||
subtitle, | ||
subtitle: _subtitle, |
Copilot
AI
Oct 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The subtitle
parameter is renamed to _subtitle
but never used. Since this is a breaking change to the component interface, consider removing it entirely or documenting why it's being kept.
Copilot uses AI. Check for mistakes.
// Helper function to convert satoshis to BTC | ||
const satoshiToBtc = (satoshi: number): number => { | ||
return satoshi / 100000000; |
Copilot
AI
Oct 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The magic number 100000000
should be defined as a named constant (e.g., SATOSHIS_PER_BTC
) to improve readability and maintainability.
// Helper function to convert satoshis to BTC | |
const satoshiToBtc = (satoshi: number): number => { | |
return satoshi / 100000000; | |
// Number of satoshis in one BTC | |
const SATOSHIS_PER_BTC = 100000000; | |
// Helper function to convert satoshis to BTC | |
const satoshiToBtc = (satoshi: number): number => { | |
return satoshi / SATOSHIS_PER_BTC; |
Copilot uses AI. Check for mistakes.
530571f
to
a66e7d7
Compare
No description provided.