Update .goreleaser.yml to use S3 for musl files #1781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced curl commands with aws s3 cp for musl cross compilation files.
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the existing curl commands for downloading musl cross-compilation toolchains with AWS S3 commands, migrating from downloading from musl.cc to using a Babylon Labs artifact store.
- Replaced curl downloads with AWS S3 downloads for musl cross-compilation files
- Added comments marking this as a proof-of-concept change by Ricardo
- Commented out the original curl-based commands for potential rollback
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+21
to
+29
| # START - PoC Ricardo - Babylon Artifact Store | ||
| - aws s3 cp s3://babylonlabs-artifact-store/musl/latest/x86_64-linux-musl-cross.tgz . | ||
| - tar xf x86_64-linux-musl-cross.tgz | ||
| - mv -n -u x86_64-linux-musl-cross /opt/musl-cross-x86_64 | ||
|
|
||
| - curl -LO https://musl.cc/aarch64-linux-musl-cross.tgz | ||
| - aws s3 cp s3://babylonlabs-artifact-store/musl/latest/aarch64-linux-musl-cross.tgz . | ||
| - tar xf aarch64-linux-musl-cross.tgz | ||
| - mv -n -u aarch64-linux-musl-cross /opt/musl-cross-aarch64 | ||
| # END - PoC Ricardo - Babylon Artifact Store |
There was a problem hiding this comment.
The comments indicate this is a proof-of-concept change. Consider removing these temporary comments and the commented-out curl commands once the S3 approach is proven stable, or add a TODO comment with a timeline for cleanup.
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced curl commands with aws s3 cp for musl cross compilation files.