Modify goreleaser.yml for AWS and dry run #1782
Conversation
Updated GitHub Actions workflow to configure AWS credentials and added a dry run for the release process.
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the GitHub Actions workflow for releases to support AWS credential configuration and implements a dry run approach for testing the release process.
- Added AWS OIDC authentication to enable S3 operations during the build process
- Commented out the original release step and replaced it with a dry run configuration
- Added necessary permissions for OpenID Connect token usage
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| # - name: Make release | ||
| # run: make release | ||
| # env: | ||
| # GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
The original release step is commented out, which suggests this might be temporary for testing. Consider removing the commented code if the dry run approach is permanent, or add a comment explaining when to switch back to the full release.
| # - name: Make release | |
| # run: make release | |
| # env: | |
| # GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
Copilot uses AI. Check for mistakes.
| # GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| - name: Make release (dry run) | ||
| run: goreleaser release --skip=publish --skip=validate --clean |
There was a problem hiding this comment.
The dry run command skips validation which could miss potential issues. Consider removing --skip=validate to catch configuration problems early, or document why validation is being skipped.
| run: goreleaser release --skip=publish --skip=validate --clean | |
| run: goreleaser release --skip=publish --clean |
Copilot uses AI. Check for mistakes.
Updated GitHub Actions workflow to configure AWS credentials and added a dry run for the release process.