Rebase from cosmostation:develop #3

maiquanghiep · 2025-09-01T01:40:25Z

PR(Pull Request) Overview

Briefly describe the changes made in this PR.

Changes

Major feature addition or modification
Bug fix
Code improvement
Documentation update

Related Issue

Please reference the Issue number this PR addresses: #123

Description of Changes

Describe the key changes or parts of the code that have been modified.

Testing Method

Explain how to test the changes step by step: 1. Run ‘…’ 2. Check ‘…’

Additional Information

If there is any additional information relevant to this PR, please include it here.

…ippcrat Support New Chain: Add hippocrat testnet network into support_chain.yaml

…r-verifier/sync-logic Fix: axelar amplifier verifier package

…/heartbeats-for-axelar

…-axelar Add a new package : axelar-vald-heartbeats

…ts-for-axelar Add rules for axelar vald heartbeats

…ry for grpc endpoint

…oce/grpc_query fix: eventnonoce package grpc query for TLS and unregistered validator

add xrplevm mainnet params

…land Support gnoland testnet6

Supporting Terra Classic on vals dash

rename chain-id from v2 to v3

lumera-testnet migration from v1 to v2

saga-testnet chain-id update

Support 0gchain testnet

…evelop

Copilot

Pull Request Overview

This pull request contains extensive synchronization changes across the CVMS (Cosmostation Validator Monitoring System) codebase, adding support for Gnoland blockchain, enhancing Axelar functionality, and implementing various improvements and fixes.

Adds complete Gnoland blockchain support including vote indexer, block health monitoring, and API integrations
Enhances Axelar ecosystem support with new amplifier verifier functionality and VALD heartbeats monitoring
Updates test configurations and removes deprecated chain support (terra-classic)

Reviewed Changes

Copilot reviewed 88 out of 89 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
scripts/make_support_chains.sh	Removes terra-classic from ignored chains list
internal/testutil/.env.test.sample	Removes old test environment template
internal/testutil/.env.test	Adds new comprehensive test environment configuration
internal/packages/health/block/	Updates block health monitoring to support Gnoland and removes unused fields
internal/packages/gnoland/	Adds complete Gnoland vote indexer implementation
internal/packages/axelar/	Enhances Axelar amplifier verifier and adds VALD heartbeats monitoring
internal/common/	Adds Gnoland types, parsers, and API functions
internal/helper/	Updates helper functions to support Gnoland protocol

Comments suppressed due to low confidence (2)

internal/packages/health/block/types/cosmos.go:1

The removal of the ID field from CosmosV34BlockResponse may break existing code that depends on this field. Ensure all usages of this struct are updated accordingly and consider adding a migration strategy if this is a breaking change.

package types

internal/packages/health/block/api/api.go:1

Variable declaration order issue: resp is declared twice with different types. The first declaration (line 32) should be removed as it's overwritten by the second declaration (line 33).

package api

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-01T01:41:47Z

internal/packages/axelar/amplifier-verifier/indexer/sync.go

 	// first add new verifiers
 	isNewVerifier := false
-	newVerifierInfo := make([]indexermodel.VerifierInfo, 0)
+	newVerifierMap := make(map[string]bool, 0)


Using make with a capacity of 0 for a map is unnecessary. Maps don't use capacity like slices do. Use make(map[string]bool) instead.

Suggested change

newVerifierMap := make(map[string]bool, 0)

newVerifierMap := make(map[string]bool)

Copilot · 2025-09-01T01:41:48Z

internal/packages/duty/eventnonce/api/grpc.go

+	if strings.Contains(c.GetGRPCEndPoint(), ":443") {
+		tlsConf := &tls.Config{
+			NextProtos: []string{"h2"}, // only allow HTTP/2
+			MinVersion: tls.VersionTLS12,
+		}


The TLS configuration should include ServerName for proper certificate validation. Consider adding ServerName: extractHostFromEndpoint(c.GetGRPCEndPoint()) to prevent potential man-in-the-middle attacks.

Copilot · 2025-09-01T01:41:48Z

internal/common/types/cosmos.go

 }

-var CosmosConsensusParamsQueryPath = "/cosmos/consensus/v1/params"
+var CosmosConsensusParamsQueryPath = "/consensus_params"


The change from /cosmos/consensus/v1/params to /consensus_params appears to be switching from a REST API endpoint to an RPC endpoint. Ensure this change is intentional and that all dependent code is updated to handle the different response format.

Suggested change

var CosmosConsensusParamsQueryPath = "/consensus_params"

// NOTE: This is now an RPC endpoint, not REST. Response format differs from /cosmos/consensus/v1/params.

var CosmosConsensusParamsRPCQueryPath = "/consensus_params"

Copilot · 2025-09-01T01:41:48Z

internal/packages/babylon/finality-provider/indexer/batch_sync.go

 	// this logic will be progressed only when there are new tendermint validators in this block
 	if isNewFinalityProvider {
-		newfpInfoList, err := function.MakeFinalityProviderInfoList(idx.CommonClient, idx.ChainInfoID, newFinalityProviderMap)
+		newfpInfoList, err := function.MakeFinalityProviderInfoList(idx.CommonClient, chainID, idx.ChainInfoID, newFinalityProviderMap)


The function signature change adds a chainID parameter. This is a breaking change that requires all callers to be updated. Verify that all usages of MakeFinalityProviderInfoList have been updated accordingly.

Copilot · 2025-09-01T01:41:48Z

internal/common/parser/initia.go

-			Tokens:          "", // initia has multiple tokens on validators, so skip the tokens
-		})
+		// NOTE: mstaking module is not supporting status query string yet.
+		if validator.Status == types.BOND_STATUS_BONDED {


The comparison uses types.BOND_STATUS_BONDED but the validator.Status field is a string type. This will likely always be false unless types.BOND_STATUS_BONDED is also a string constant. Verify the type compatibility.

Suggested change

if validator.Status == types.BOND_STATUS_BONDED {

if validator.Status == "Bonded" {

….1.3

V1.1.3

* Create publish.yml * Update publish.yml

Jeongseup and others added 30 commits February 19, 2025 18:54

Fix axelar-amplifier-verifier

6486a17

feat: Add heartbeats metric exporter for axelar-evm

d6565c7

Resolve merge conflicts

1228a9c

Add balance under rule for Nym-api validator

f6bbf01

Add hippocrat network into support_chain.yaml

a7f6c1d

Merge pull request cosmostation#74 from Jeongseup/add-support-chain/h…

8ea477f

…ippcrat Support New Chain: Add hippocrat testnet network into support_chain.yaml

Update babylon dashboard

199d50c

Update neutron mainnet for disabling consumer chain option

0281d17

Update logic

fd39e14

Extract unique verifier & Add XprlVotingVerififer address

ae0f254

Merge pull request cosmostation#75 from Jeongseup/fix/axelar-amplifie…

8f7ff40

…r-verifier/sync-logic Fix: axelar amplifier verifier package

Merge branch 'develop' of https://github.com/BOSEES/cvms into feature…

95e0bea

…/heartbeats-for-axelar

Add block-data-analytic into axelar chain

1365372

Update collector in block-data-analytics package

7e521ef

Update get consensus param query

da06dfa

Update dashboard

d7af36e

Update default variable for axelar dashboard

adf7fb9

Refactor package for axelar vald heartbeats

d332ef1

Merge branch 'develop' into feature/heartbeats-for-axelar

7f79c1b

Merge pull request cosmostation#56 from BOSEES/feature/heartbeats-for…

77d0bad

…-axelar Add a new package : axelar-vald-heartbeats

Add rules for axelar vald heartbeats

f0ebaca

Merge pull request cosmostation#78 from cosmostation/feature/heartbea…

bcd30f2

…ts-for-axelar Add rules for axelar vald heartbeats

Fix grpc query for unregistered validator in gravity & Enable TLS que…

5a94849

…ry for grpc endpoint

Add test env file

6684e9d

Merge pull request cosmostation#79 from cosmostation/feature/eventnon…

462c62a

…oce/grpc_query fix: eventnonoce package grpc query for TLS and unregistered validator

Update for custom rules

5f452ed

Update axelar amplifier verifier alert rule

aafc805

add xrplevm mainnet params

832511e

mainnet flag update

9f9b476

Merge pull request cosmostation#81 from kimheeje12/develop

1ee51e2

add xrplevm mainnet params

niodamian and others added 20 commits June 5, 2025 19:17

Update support_chains-cm.yaml

3f33bc0

Update block data analytics indexer point to latest

367545a

Support gnoland testnet6

aec015f

Support gnoland voteindexer

eb08892

Update gnoland chainname in support chains

c3cfbe7

Add gnoland dashboard

6e78c54

modify codes for whitespace in golanglint-ci

7464ed1

Update api logic by dupl

b72c9b9

Merge pull request cosmostation#91 from Jeongseup/feature/support-gno…

2c92307

…land Support gnoland testnet6

Merge pull request cosmostation#88 from niodamian/develop

36348d5

Supporting Terra Classic on vals dash

saga-testnet chain-id update

f237478

rename chain-id from v2 to v3

Update support_chains.yaml for lumera-testnet

7987e64

lumera-testnet migration from v1 to v2

Merge pull request cosmostation#93 from afa-farkhod/saga-testnet-update

3eb1acd

saga-testnet chain-id update

Support 0gchain testnet

b82d483

Merge pull request cosmostation#94 from Jeongseup/support/add-0gchain

17e0380

Support 0gchain testnet

Update imua testnet chain-id by upgrade

cc13715

Disable empty orchestrator address log for eventnonce

df0269f

Add sample dashboard for saga testnet

0b4bcd0

Add sample public cvms dashboard

e3393ff

Merge branch 'develop' of https://github.com/cosmostation/cvms into d…

e28fd69

…evelop

Copilot AI review requested due to automatic review settings September 1, 2025 01:40

Copilot AI reviewed Sep 1, 2025

View reviewed changes

maiquanghiep changed the title ~~Sync~~ Rebase from cosmostation:develop Sep 1, 2025

BOSEES and others added 5 commits September 30, 2025 11:24

Remove stale metric reset logic for babylon finality-provider

dd51b51

Remove stale metric reset logic for babylon finality-provider

6259b86

Merge branch 'v1.1.3' of https://github.com/cosmostation/cvms into v1…

5ced1fa

….1.3

Merge pull request cosmostation#98 from BOSEES/v1.1.3

eed582a

V1.1.3

Add CI (#2)

9d59f4e

* Create publish.yml * Update publish.yml

maiquanghiep force-pushed the hiep/sync branch from 04b289a to 9d59f4e Compare September 30, 2025 06:45

update

b014d30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rebase from cosmostation:develop #3

Rebase from cosmostation:develop #3

Uh oh!

maiquanghiep commented Sep 1, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Sep 1, 2025

Uh oh!

Copilot AI Sep 1, 2025

Uh oh!

Copilot AI Sep 1, 2025

Uh oh!

Copilot AI Sep 1, 2025

Uh oh!

Copilot AI Sep 1, 2025

Uh oh!

Uh oh!

	newVerifierMap := make(map[string]bool, 0)
	newVerifierMap := make(map[string]bool)

	var CosmosConsensusParamsQueryPath = "/consensus_params"
	// NOTE: This is now an RPC endpoint, not REST. Response format differs from /cosmos/consensus/v1/params.
	var CosmosConsensusParamsRPCQueryPath = "/consensus_params"

	if validator.Status == types.BOND_STATUS_BONDED {
	if validator.Status == "Bonded" {

Rebase from cosmostation:develop #3

Are you sure you want to change the base?

Rebase from cosmostation:develop #3

Uh oh!

Conversation

maiquanghiep commented Sep 1, 2025

PR(Pull Request) Overview

Changes

Related Issue

Description of Changes

Testing Method

Additional Information

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Sep 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 1, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!