- 
                Notifications
    
You must be signed in to change notification settings  - Fork 18
 
Feature/crashloop #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            konst-sauce
  wants to merge
  17
  commits into
  master
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
feature/crashloop
  
      
      
   
  
    
  
  
  
 
  
      
    base: master
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
  
     Open
                    Feature/crashloop #100
Changes from 8 commits
      Commits
    
    
            Show all changes
          
          
            17 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      ee4952a
              
                Added BacktraceCrashLoopDetector
              
              
                konst-sauce 861aa76
              
                Added public methods to configure safe mode and access its state. Rem…
              
              
                konst-sauce b8d9679
              
                Added detection to iOS example. Moved detection to isSafeToLaunch
              
              
                konst-sauce 3d18e2f
              
                Added Unit Tests, added logs, polished CL detector
              
              
                konst-sauce 8c07770
              
                Removed PLCR dependency from BTCL detector, added UI, polishes
              
              
                konst-sauce c290660
              
                Polished naming, added reset of CL detector when safe mode is necessary
              
              
                konst-sauce f0f9d56
              
                Polished crash loop detection
              
              
                konst-sauce dc9fba3
              
                Updated tvOS and macOS examples
              
              
                konst-sauce 8497a45
              
                Updated with comments from the pull request review
              
              
                konst-sauce 3fc8bf6
              
                Added Crash Loop counter
              
              
                konst-sauce 03d6cd0
              
                Polished Crash Loop detection
              
              
                konst-sauce 0c3e486
              
                Updated crash loop detector algorithm, polished names, added comments.
              
              
                konst-sauce d0d63d6
              
                Final polishes - updated CLD algorithm, updated all examples to utili…
              
              
                konst-sauce c08a971
              
                Polished for comments in PR
              
              
                konst-sauce 35258e3
              
                backtrace.version attribute fix
              
              
                konst-sauce 742e021
              
                CLD algorithm polished. Some PR comments utilised.
              
              
                konst-sauce 887589e
              
                Polished other example apps, fixed bug.
              
              
                konst-sauce File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -1,7 +1,8 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <document type="com.apple.InterfaceBuilder3.Cocoa.Storyboard.XIB" version="3.0" toolsVersion="14460.31" targetRuntime="MacOSX.Cocoa" propertyAccessControl="none" useAutolayout="YES" initialViewController="B8D-0N-5wS"> | ||
| <document type="com.apple.InterfaceBuilder3.Cocoa.Storyboard.XIB" version="3.0" toolsVersion="20037" targetRuntime="MacOSX.Cocoa" propertyAccessControl="none" useAutolayout="YES" initialViewController="B8D-0N-5wS"> | ||
| <dependencies> | ||
| <plugIn identifier="com.apple.InterfaceBuilder.CocoaPlugin" version="14460.31"/> | ||
| <deployment identifier="macosx"/> | ||
| <plugIn identifier="com.apple.InterfaceBuilder.CocoaPlugin" version="20037"/> | ||
| <capability name="documents saved in the Xcode 8 format" minToolsVersion="8.0"/> | ||
| </dependencies> | ||
| <scenes> | ||
| 
          
            
          
           | 
    @@ -619,7 +620,7 @@ | |
| <menuItem title="Show Sidebar" keyEquivalent="s" id="kIP-vf-haE"> | ||
| <modifierMask key="keyEquivalentModifierMask" control="YES" command="YES"/> | ||
| <connections> | ||
| <action selector="toggleSourceList:" target="Ady-hI-5gd" id="iwa-gc-5KM"/> | ||
| <action selector="toggleSidebar:" target="Ady-hI-5gd" id="iwa-gc-5KM"/> | ||
| </connections> | ||
| </menuItem> | ||
| <menuItem title="Enter Full Screen" keyEquivalent="f" id="4J7-dP-txa"> | ||
| 
          
            
          
           | 
    @@ -710,7 +711,7 @@ | |
| <autoresizingMask key="autoresizingMask"/> | ||
| <subviews> | ||
| <button verticalHuggingPriority="750" translatesAutoresizingMaskIntoConstraints="NO" id="Snf-7p-7db"> | ||
| <rect key="frame" x="4" y="3" width="472" height="61"/> | ||
| <rect key="frame" x="3" y="3" width="474" height="62"/> | ||
| <constraints> | ||
| <constraint firstAttribute="height" constant="50" id="wS4-BS-4BZ"/> | ||
| </constraints> | ||
| 
        
          
        
         | 
    @@ -719,7 +720,7 @@ | |
| <font key="font" metaFont="system"/> | ||
| </buttonCell> | ||
| <connections> | ||
| <action selector="liveReportButtonAction:" target="XfG-lQ-9wD" id="r4X-yE-pnP"/> | ||
| <action selector="crashAction:" target="XfG-lQ-9wD" id="OfJ-Ce-bpL"/> | ||
| 
         There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. shouldn't liveReportButton stay here?  | 
||
| </connections> | ||
| </button> | ||
| <scrollView borderType="none" horizontalLineScroll="10" horizontalPageScroll="10" verticalLineScroll="10" verticalPageScroll="10" hasHorizontalScroller="NO" translatesAutoresizingMaskIntoConstraints="NO" id="FmX-dS-tKd"> | ||
| 
        
          
        
         | 
    @@ -739,6 +740,10 @@ | |
| </textView> | ||
| </subviews> | ||
| </clipView> | ||
| <scroller key="horizontalScroller" hidden="YES" wantsLayer="YES" verticalHuggingPriority="750" horizontal="YES" id="KrE-Pr-E3e"> | ||
| <rect key="frame" x="-100" y="-100" width="460" height="16"/> | ||
| <autoresizingMask key="autoresizingMask"/> | ||
| </scroller> | ||
| <scroller key="verticalScroller" wantsLayer="YES" verticalHuggingPriority="750" horizontal="NO" id="7RO-Uj-aNq"> | ||
| <rect key="frame" x="444" y="0.0" width="16" height="190"/> | ||
| <autoresizingMask key="autoresizingMask"/> | ||
| 
          
            
          
           | 
    ||
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Uh oh!
There was an error while loading. Please reload this page.