react-native example: update to react-native 0.75.3 boilerplate code #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konraddysput
requested changes
Sep 27, 2024
Collaborator
There was a problem hiding this comment.
- wrong application name
- Did you run the app natively on the phone? I think due to the new namespace and lack of changes in the javascript binding, we're not able to trigger an error
- We're missing java unhandled exception generator (it was removed)
- we need to be sure source maps are being generated on the android and ios. the xcode solution task doesn't have source map generation script
examples/sdk/reactNative/android/app/src/main/res/values/strings.xml
Outdated
Show resolved
Hide resolved
examples/sdk/reactNative/android/app/src/main/java/com/reactnative/BacktraceDemoPackage.java
Show resolved
Hide resolved
examples/sdk/reactNative/android/app/src/main/java/com/rnbtexample/MainActivity.kt
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,37 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
Collaborator
There was a problem hiding this comment.
if we're adding it - we need to extend the list - example: https://github.com/backtrace-labs/backtrace-cocoa/blob/master/Sources/Resources/PrivacyInfo.xcprivacy
examples/sdk/reactNative/ios/rnbtexampleTests/rnbtexampleTests.m
Outdated
Show resolved
Hide resolved
perf2711
force-pushed
the
feature/react-native-example-update
branch
2 times, most recently
from
d1e9d5e to
ec9ade7
Compare
konraddysput
reviewed
Oct 1, 2024
examples/sdk/reactNative/android/app/src/main/java/com/reactnative/ErrorGenerator.java
Outdated
Show resolved
Hide resolved
examples/sdk/reactNative/android/app/src/main/java/com/reactnative/MainApplication.java
Outdated
Show resolved
Hide resolved
konraddysput
approved these changes
Oct 2, 2024
Collaborator
konraddysput
left a comment
konraddysput
left a comment
There was a problem hiding this comment.
If we want to land this change we need to also fix the problem with crash support on the newest gradle. Please wait on other changes before landing it
…pplication.getPackages
perf2711
force-pushed
the
feature/react-native-example-update
branch
from
2c18235 to
05a99b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
react-nativeexample toreact-native@0.75.3.The code was created using
npx @react-native-community/cli@latest init rnbtexample.