Skip to content

node: fix invalid breadcrumb name in FileBreadcrumbsStorage #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 22, 2024
Merged

node: fix invalid breadcrumb name in FileBreadcrumbsStorage #303

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ff2abfd
node: fix invalid breadcrumb name in FileBreadcrumbsStorage
perf2711 Oct 21, 2024
47e71ef
node: use getAttachments in getAttachmentProviders in FileBreadcrumbs…
perf2711 Oct 21, 2024
6f728eb
node: add unit tests for attachment names from FileBreadcrumbsStorage
perf2711 Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/node/src/breadcrumbs/FileBreadcrumbsStorage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ export class FileBreadcrumbsStorage implements BreadcrumbsStorage {
{
get: () => {
const files = [...this._sink.files].map((f) => f.path.toString('utf-8'));
return files.map((f) => new BacktraceFileAttachment(f, f, this._fileSystem));
return files.map((f) => new BacktraceFileAttachment(f, path.basename(f), this._fileSystem));
},
type: 'dynamic',
},
Expand Down