sourcemap-tools: add processSource to SourceProcessor #332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konraddysput
force-pushed
the
feature/sourcemap-tools-process-source
branch
from
324f66f to
f25156f
Compare
perf2711
approved these changes
Jan 21, 2025
perf2711
requested changes
Jan 23, 2025
Comment on lines
165
to
167
| if (!sourceMap) { | ||
| return { debugId, source: newSource }; | ||
| } |
There was a problem hiding this comment.
I wonder why it doesn't show an error here? ProcessResult expects sourceMap to be set.
Can you add a new interface called ProcessResultWithoutSourcemap (this will reduce refactoring in other packages) and annotate this function like this:
public async processSourceAndSourceMap(
source: string,
sourceMap: RawSourceMap,
debugId?: string,
force?: boolean,
): Promise<ProcessResult>;
public async processSourceAndSourceMap(
source: string,
sourceMap?: undefined,
debugId?: string,
force?: boolean,
): Promise<ProcessResultWithoutSourcemap>;
public async processSourceAndSourceMap(
source: string,
sourceMap?: RawSourceMap,
debugId?: string,
force?: boolean,
): Promise<ProcessResult> {
Also, change the return type on processSource to return Promise<ProcessResultWithoutSourcemap>.
There was a problem hiding this comment.
So it DOES return an error!
There was a problem hiding this comment.
But not on build... strange.
added 2 commits
January 23, 2025 15:25
perf2711
approved these changes
Jan 23, 2025
konraddysput
added a commit
that referenced
this pull request
Jan 23, 2025
* sourcemap-tools: add processSource to SourceProcessor * sourcemap-tools: abstract processing code to the common method * sourcemap-tools: Provide better abstraction & definition for processSourceAndAvailableSourceMap * sourcemap-tools: private processSourceAndAvailableSourceMap --------- Co-authored-by: Sebastian Alex <sebastian.alex@saucelabs.com> Co-authored-by: Konrad Dysput <konrad.dysput@saucelabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This change exposes an option in the sourcemap-tools to process source maps via translation process (for example: via metro in react-native)
ref: BT-5175