Explicitly set target linker language for compat CMakeLists.txt #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes compatibility with CMake's Ninja generator
KrzaQ
force-pushed
the
fix-linux-ninja-build
branch
9 times, most recently
from
875fed3 to
91f2f18
Compare
|
I've submitted #34 as well |
|
And removed the other commit from #29, it does pass with current CI setup |
KrzaQ
force-pushed
the
fix-linux-ninja-build
branch
7 times, most recently
from
ec17471 to
bca9622
Compare
|
any updates? |
|
Hi, sorry for the delay! I expect to work on this (and hopefully be done) towards the end of this week. |
KrzaQ
force-pushed
the
fix-linux-ninja-build
branch
6 times, most recently
from
7e798dc to
7ab634b
Compare
|
It looks like I finally got the tests working. I'll proceed with this today |
KrzaQ
force-pushed
the
fix-linux-ninja-build
branch
from
7ab634b to
310d064
Compare
konraddysput
approved these changes
Mar 30, 2023
|
It seems you will have to update the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes compatibility with CMake's Ninja generator