Sensorfusion #2
Open
Sensorfusion #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YVishere
requested changes
Nov 30, 2025
Collaborator
YVishere
left a comment
YVishere
left a comment
There was a problem hiding this comment.
Hey, strong start and we could merge this with as a working version after testing it and with a few changes,
-- Can you move the getPitch() and getRoll() methods initialization from the header file to the .cpp file. We can just have them declared in the header file (just having the method header like int getPitch() in the header file lets you use this method in main.cpp).
It helps to keep the organization uniform in case someone else wants to work on it in future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First iteration of sensorfusion