fix: use generator expression for Xcode post-build resource symlink #9258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The post-build script that creates the Resources symlink was hardcoded to use the 'Debug' configuration path regardless of the actual build configuration. This caused builds to fail with 'No such file or directory' when building Release (or any non-Debug) configuration with Xcode generator. Replace the hardcoded 'Debug' with CMake's $<CONFIG> generator expression which correctly resolves to the actual build configuration at build time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The post-build script that creates the Resources symlink was hardcoded to use the
Debugconfiguration path regardless of the actual build configuration:This caused builds to fail with:
Solution
Replace the hardcoded
"Debug"with CMake's$<CONFIG>generator expression, which correctly resolves to the actual build configuration (Release, Debug, etc.) at build time.Testing
./BuildMac.sh(Release configuration)