Skip to content

fix: config TrayMessageShown not work #1217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vtumi wants to merge 4 commits into from
Closed

fix: config TrayMessageShown not work #1217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9244a5b
fix: config TrayMessageShown not work
vtumi Oct 13, 2025
26e6f45
Update windows.yml
vtumi Oct 13, 2025
a399fbd
Update dialog.cpp
vtumi Oct 13, 2025
67d5323
Update main.cpp
vtumi Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ on:
- '!QtScrcpy/res/**'
- '.github/workflows/windows.yml'
- 'ci/win**'
workflow_dispatch:
jobs:
build:
name: Build
Expand Down Expand Up @@ -113,4 +114,4 @@ jobs:
file: ci\build\${{ steps.package.outputs.package-name }}.zip
asset_name: ${{ steps.package.outputs.package-name }}.zip
tag: ${{ github.ref }}
overwrite: true
overwrite: true
12 changes: 0 additions & 12 deletions QtScrcpy/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,18 +112,6 @@ int main(int argc, char *argv[])
g_mainDlg = new Dialog {};
g_mainDlg->show();

qInfo() << QObject::tr("This software is completely open source and free. Use it at your own risk. You can download it at the "
Copy link
Owner

@barry-ran barry-ran Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete my money ？

Copy link
Author

@vtumi vtumi Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error request, please remove it.

"following address:");
qInfo() << QString("QtScrcpy %1 <https://github.com/barry-ran/QtScrcpy>").arg(QCoreApplication::applicationVersion());

qInfo() << QObject::tr("If you need more professional batch control mirror software, you can try the following software:");
qInfo() << QString(QObject::tr("QuickMirror") + " <https://lrbnfell4p.feishu.cn/drive/folder/KviYfz5uFlpUT8dXgdjccmfUnse>");

qInfo() << QObject::tr("If you need more professional game keymap mirror software, you can try the following software:");
qInfo() << QString(QObject::tr("QuickAssistant") + " <https://lrbnfell4p.feishu.cn/drive/folder/Hqckfxj5el1Wjpd9uezcX71lnBh>");

qInfo() << QObject::tr("You can contact me with telegram <https://t.me/+Ylf_5V_rDCMyODQ1>");

int ret = a.exec();
delete g_mainDlg;

Expand Down
13 changes: 8 additions & 5 deletions QtScrcpy/ui/dialog.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,11 @@ Dialog::Dialog(QWidget *parent) : QWidget(parent), ui(new Ui::Widget)
m_menu->addAction(m_showWindow);
m_menu->addAction(m_quit);
m_hideIcon->setContextMenu(m_menu);
m_hideIcon->show();

if (Config::getInstance().getTrayMessageShown()) {
m_hideIcon->show();
}

connect(m_showWindow, &QAction::triggered, this, &Dialog::show);
connect(m_quit, &QAction::triggered, this, [this]() {
m_hideIcon->hide();
Expand Down Expand Up @@ -301,15 +305,14 @@ void Dialog::slotActivated(QSystemTrayIcon::ActivationReason reason)

void Dialog::closeEvent(QCloseEvent *event)
{
this->hide();
if (!Config::getInstance().getTrayMessageShown()) {
Config::getInstance().setTrayMessageShown(true);
if (Config::getInstance().getTrayMessageShown()) {
this->hide();
m_hideIcon->showMessage(tr("Notice"),
tr("Hidden here!"),
QSystemTrayIcon::Information,
3000);
event->ignore();
}
event->ignore();
}

void Dialog::on_updateDevice_clicked()
Expand Down