Skip to content

Conversation

bartholomej
Copy link
Owner

What's new and why I made this pull request?

  • Parsing all cinemas

Pull request type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Tests
[ ] Other

@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2023

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 96.59091% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.05%. Comparing base (ffbb579) to head (2a75d04).

Files with missing lines Patch % Lines
src/index.ts 71.42% 2 Missing ⚠️
src/helpers/cinema.helper.ts 98.33% 1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##           master      #38       +/-   ##
===========================================
+ Coverage   80.07%   99.05%   +18.98%     
===========================================
  Files          24       26        +2     
  Lines         557      531       -26     
  Branches      112      102       -10     
===========================================
+ Hits          446      526       +80     
+ Misses         95        5       -90     
+ Partials       16        0       -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds functionality to parse cinema data from CSFD, introducing a new cinema scraping service that fetches theater information, showtimes, and movie screenings by district and time period.

  • Implements a new CinemaScraper service to fetch and parse cinema data
  • Adds cinema interfaces and helper functions for data extraction
  • Integrates cinema functionality into the main API with server endpoint

Reviewed Changes

Copilot reviewed 10 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
vitest.config.mts Excludes server.ts from test coverage
tests/cinema.service.test.ts Adds comprehensive tests for cinema scraper functionality
tests/cinema.helper.test.ts Tests helper functions for parsing cinema data from HTML
src/vars.ts Adds URL generator for cinema endpoints
src/services/cinema.service.ts Implements the main cinema scraping service
src/interfaces/cinema.interface.ts Defines TypeScript interfaces for cinema data structures
src/index.ts Integrates cinema service into main CSFD class
src/helpers/cinema.helper.ts Helper functions for extracting cinema data from HTML
server.ts Adds new /cinemas API endpoint
demo.ts Updates demo to showcase cinema functionality

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@bartholomej bartholomej requested a review from Copilot September 12, 2025 16:33
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 11 out of 13 changed files in this pull request and generated 4 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@bartholomej bartholomej requested a review from Copilot September 12, 2025 16:38
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 11 out of 13 changed files in this pull request and generated 4 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@bartholomej bartholomej changed the title Cinemas [WIP] Cinemas Sep 12, 2025
@bartholomej bartholomej marked this pull request as ready for review September 12, 2025 16:45
@bartholomej bartholomej merged commit d24d134 into master Sep 12, 2025
1 check passed
@bartholomej bartholomej deleted the cinemas branch September 12, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants