-
-
Notifications
You must be signed in to change notification settings - Fork 9
Cinemas #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cinemas #38
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #38 +/- ##
===========================================
+ Coverage 80.07% 99.05% +18.98%
===========================================
Files 24 26 +2
Lines 557 531 -26
Branches 112 102 -10
===========================================
+ Hits 446 526 +80
+ Misses 95 5 -90
+ Partials 16 0 -16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
efd62fa
to
36bc770
Compare
85857a8
to
42b71c5
Compare
facf1f2
to
5248be4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds functionality to parse cinema data from CSFD, introducing a new cinema scraping service that fetches theater information, showtimes, and movie screenings by district and time period.
- Implements a new CinemaScraper service to fetch and parse cinema data
- Adds cinema interfaces and helper functions for data extraction
- Integrates cinema functionality into the main API with server endpoint
Reviewed Changes
Copilot reviewed 10 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
vitest.config.mts | Excludes server.ts from test coverage |
tests/cinema.service.test.ts | Adds comprehensive tests for cinema scraper functionality |
tests/cinema.helper.test.ts | Tests helper functions for parsing cinema data from HTML |
src/vars.ts | Adds URL generator for cinema endpoints |
src/services/cinema.service.ts | Implements the main cinema scraping service |
src/interfaces/cinema.interface.ts | Defines TypeScript interfaces for cinema data structures |
src/index.ts | Integrates cinema service into main CSFD class |
src/helpers/cinema.helper.ts | Helper functions for extracting cinema data from HTML |
server.ts | Adds new /cinemas API endpoint |
demo.ts | Updates demo to showcase cinema functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 11 out of 13 changed files in this pull request and generated 4 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 11 out of 13 changed files in this pull request and generated 4 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
46f86d2
to
2a75d04
Compare
What's new and why I made this pull request?
Pull request type
What kind of change does this PR introduce?