model_cache: break if the files have changed since last revision in jinja template #1664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ) | ||
| model_cache_hash += hash_v1 | ||
|
|
||
| if config.model_cache.is_v2: |
There was a problem hiding this comment.
Is v1/v2 mutually exclusive? The control flow structure looks a bit unintuitive here.
There was a problem hiding this comment.
theoretically, they are mutually exclusive.
There was a problem hiding this comment.
The idea is just to break the legacy v1 cache.
| RUN mkdir -p /app/model_cache | ||
| WORKDIR /app | ||
|
|
||
| RUN "echo hash {{model_cache_hash}}" |
There was a problem hiding this comment.
Are the quotes intentional?
If model_cache_hash is the hash value, what is the purpose of the hash command here?
There was a problem hiding this comment.
its to break the model cache here / command below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 What
💻 How
🔬 Testing