Skip to content

properly disable ws pings #1927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

properly disable ws pings #1927

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f2e58e
properly disable ws pings
bryzhang Sep 15, 2025
5319236
oops
bryzhang Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion truss/templates/server/truss_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,19 +465,23 @@ def start(self):
else "INFO"
)
extra_kwargs = {}
# We don't pass these if not set, to not override the default.
if (
ws_ping_interval_seconds := self._config["runtime"]
.get("transport", {})
.get("ping_interval_seconds")
):
extra_kwargs["ws_ping_interval"] = ws_ping_interval_seconds
else:
extra_kwargs["ws_ping_interval"] = None

if (
ws_ping_timeout_seconds := self._config["runtime"]
.get("transport", {})
.get("ping_timeout_seconds")
):
extra_kwargs["ws_ping_timeout"] = ws_ping_timeout_seconds
else:
extra_kwargs["ws_ping_timeout"] = None

cfg = uvicorn.Config(
self.create_application(),
Expand Down
Loading