Skip to content

Conversation

mderazon
Copy link

@mderazon mderazon commented Jun 7, 2021

No description provided.

@mderazon mderazon mentioned this pull request Jun 7, 2021
@Esqarrouth
Copy link

Status of this? @batista

@batista
Copy link
Owner

batista commented Aug 31, 2022

Status of this? @batista

@goktugyil I haven't been able to dedicate time for this topic.

I do not want to make breaking changes as the existing default behavior is with regex.

Having said that, I'm keen on accepting a PR that extends the current interface with a flag that optionally switches from regex to glob.

Are you interested in making such proposal?

Or maybe @mderazon if you're still interested in getting this merged.

@Esqarrouth
Copy link

Are you interested in making such proposal?

Sorry, I'd love to but I don't have the required understanding for building such a proposal. But, if you have a general idea of how it would be implemented, what is changed where, please share

@mderazon
Copy link
Author

mderazon commented Aug 31, 2022

Yeah it's been some time for me as well, I guess it's a breaking change that's why I bumped a major version.

For my use case, having glob as an input made more sense, as I wanted also to match multiple folders and the syntax is already familiar.

I understand that it wasn't @batista's idea when he wrote it, that's why it wasn't merged until now.
IMHO, adding this as a config in a non breaking change is not a great option.

@goktugyil you are welcome to use the other version if it suits you better, it's open source after all...
https://github.com/scheduleonce/lint-filenames

In any case, thank you very much for writing this action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants