-
Notifications
You must be signed in to change notification settings - Fork 6
Suggestion to use glob for path matching #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Status of this? @batista |
@goktugyil I haven't been able to dedicate time for this topic. I do not want to make breaking changes as the existing default behavior is with regex. Having said that, I'm keen on accepting a PR that extends the current interface with a flag that optionally switches from regex to glob. Are you interested in making such proposal? Or maybe @mderazon if you're still interested in getting this merged. |
Sorry, I'd love to but I don't have the required understanding for building such a proposal. But, if you have a general idea of how it would be implemented, what is changed where, please share |
Yeah it's been some time for me as well, I guess it's a breaking change that's why I bumped a major version. For my use case, having glob as an input made more sense, as I wanted also to match multiple folders and the syntax is already familiar. I understand that it wasn't @batista's idea when he wrote it, that's why it wasn't merged until now. @goktugyil you are welcome to use the other version if it suits you better, it's open source after all... In any case, thank you very much for writing this action |
…d in package.json
…ion, and refactor error handling in main.ts
…ml, and refactor error handling in main.ts
No description provided.