-
Notifications
You must be signed in to change notification settings - Fork 48
Publish to NPM registry. #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
From looking at the current npmjs project. I expect that @jasonkarns should take a look at this, as in order to successfully publish to npmjs, we need an access token for the project. |
I ran into #70 as well today; it'd be great if this PR could fix that. Is @jasonkarns still the person that should look at this? |
@jasonkarns, are you the person to take a look at this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened #81 to use the release workflow I've settled on for nodenv. Left some comments here so I can understand which additional pieces might still make sense to pull into that PR.
@@ -4,7 +4,7 @@ | |||
"description": "Common assertions for Bats", | |||
"homepage": "https://github.com/bats-core/bats-assert", | |||
"license": "CC0-1.0", | |||
"author": "Zoltán Tömböl (https://github.com/ztombol)", | |||
"author": "Bats-core Organization", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ztombol is still the author of this package, even though he's not an active contributor. If we want to list the bats core org, they would be contributors, AFAIUI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, so we should just add him to the contributors and remove the author field altogether? Author is a very singular sounding field, and this is no longer authored by one person/entity.
closing with #81 having landed. but i appreciate the work put into this and the ideas shared within. will have followup PRs to reflect the package authorship cleanup and additional tests. |
Summary of changes:
This PR addressing
#70: bats-core/bats-core#1107