Skip to content

Apply PEP561 #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 20, 2024
Merged

Apply PEP561 #520

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5069ca9
chore: add py.typed
phi-friday Sep 20, 2024
59785c5
chore: add py.typed explicitly
phi-friday Sep 20, 2024
3b9ac6f
Revert "chore: add py.typed explicitly"
phi-friday Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file added bayes_opt/py.typed
View file
Open in desktop
Empty file.
5 changes: 4 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,10 @@ description = "Bayesian Optimization package"
authors = ["Fernando Nogueira"]
license = "MIT"
readme = "README.md"
packages = [{include = "bayes_opt"}]
packages = [
{include = "bayes_opt"},
{include = "bayes_opt/py.typed"},
Copy link
Member

@till-m till-m Sep 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems this explicit include might not actually be necessary.

Copy link
Contributor Author

@phi-friday phi-friday Sep 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In local, I ran the poetry build command to verify that py.typed was included.
But I prefer to be explicit rather than implicit.
Of course, this is just my personal preference, but if you prefer simplicity, it seems better to remove it.
I'll fix it as soon as you point it out.

Copy link
Contributor Author

@phi-friday phi-friday Sep 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed it

]

[tool.poetry.dependencies]
python = "^3.9"
Expand Down
Loading