Skip to content

build: add flag_alias definition for Starlarkification of python flags #3450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aranguyen wants to merge 7 commits into
base: main
Choose a base branch
from
+7 −2
Open

build: add flag_alias definition for Starlarkification of python flags #3450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7b52502
add flag_alias definition for Starlarkification of python flags
aranguyen Dec 10, 2025
e9688b7
Merge branch 'main' into main
rickeylev Dec 14, 2025
15687f1
Merge branch 'bazel-contrib:main' into main
aranguyen Dec 18, 2025
5c6539e
fix error
aranguyen Dec 18, 2025
504ccf3
use starlark flags instead
aranguyen Dec 18, 2025
effbe4c
fix starlark label
aranguyen Dec 18, 2025
e7bc464
remove extra character
aranguyen Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,3 +458,8 @@ uv_dev = use_extension(
uv_dev.configure(
version = "0.6.2",
)

flag_alias(name = "build_python_zip", starlark_flag = "//python/config_settings:build_python_zip")
flag_alias(name = "incompatible_default_to_explicit_init_py", starlark_flag = "//python/config_settings:incompatible_default_to_explicit_init_py")
flag_alias(name = "python_path", starlark_flag = "//python/config_settings:python_path")
flag_alias(name = "experimental_python_import_all_repositories", starlark_flag = "//python/config_settings:experimental_python_import_all_repositories")
2 changes: 1 addition & 1 deletion tests/base_rules/py_executable_base_tests.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ def _test_basic_zip(name, config):
# platforms.
# Pass value to both native and starlark versions of the flag until
# the native one is removed.
"//command_line_option:build_python_zip": "true",
"//python/config_settings:build_python_zip": "true",
labels.BUILD_PYTHON_ZIP: True,
"//command_line_option:cpu": "linux_x86_64",
"//command_line_option:crosstool_top": CROSSTOOL_TOP,
Expand Down
2 changes: 1 addition & 1 deletion tests/config_settings/transition/multi_version_tests.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ def _setup_py_binary_windows(name, *, impl, build_python_zip):
target = name + "_subject",
impl = impl,
config_settings = {
"//command_line_option:build_python_zip": str(build_python_zip),
"//python/config_settings:build_python_zip": str(build_python_zip),
labels.BUILD_PYTHON_ZIP: build_python_zip,
"//command_line_option:extra_toolchains": CC_TOOLCHAIN,
"//command_line_option:platforms": str(platform_targets.WINDOWS_X86_64),
Expand Down