Feature/bazel8 #951
Open
Feature/bazel8 #951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iMostfa
force-pushed
the
feature/bazel8
branch
from
4721cd0 to
d6f4aa1
Compare
This commit adds full support for Bazel 8 while maintaining backward compatibility with Bazel 7. Changes: - Fix ObjcInfo provider compatibility: Add hasattr checks for fields removed in Bazel 8 (force_load_library, imported_library, library, static_framework_file, etc.) - Handle AppleDynamicFramework provider removal: Add conditional checks and fallbacks for the removed provider - Update MODULE.bazel dependencies to Bazel 8-compatible versions: - apple_support: 1.15.1 → 1.21.1 - rules_cc: 0.0.10 → 0.0.16 - bazel_skylib: 1.4.2 → 1.7.1 - rules_pkg: 0.9.1 → 1.0.1 - stardoc: 0.6.2 → 0.7.2 - Add bazel_version.bzl utility for runtime version detection - Update CI to test with both Bazel 7.1.0 and 8.0.0 - Add Bazel 8 migration guide to README - Add compatibility test script Fixes compatibility issues when using rules_ios with Bazel 8.0.0 Cleanup
iMostfa
force-pushed
the
feature/bazel8
branch
3 times, most recently
from
23bec13 to
5aca660
Compare
This commit addresses linking problems that arose with Bazel 8 where transitive Swift and ObjC dependencies were not being properly linked. Changes: - objc_provider_utils.bzl: Return struct instead of None for dynamic frameworks in Bazel 8 to maintain framework information - framework_middleman.bzl: - Add SwiftInfo collection and propagation - Collect libraries from ObjcInfo and add to CcInfo linking context - Handle .lo files (from alwayslink libraries) properly - Remove unsupported dynamic_framework_file from ObjcInfo in Bazel 8 - Add toolchains to dep_middleman rule - framework.bzl: Re-add .lo file collection (critical for alwayslink) These changes ensure all transitive dependencies are properly included in the linking phase, fixing "undefined symbols" errors.
iMostfa
force-pushed
the
feature/bazel8
branch
from
5aca660 to
e453871
Compare
|
@jschear Would appreciate your support here. |
|
Hi @iMostfa, thanks for contributing -- I'll take a look tomorrow or early next week! |
|
i discovered that tests discovery isn't working, trying to get what caused it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Adds initial support for Bazel 8
tests appears to be passing, but i need some expertise as most of my changes were just fixing errors, and trusting LLMs 😂