Print interactive debug instructions in HardlinkedSandboxedSpawn #26581
+29
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running with --experimental_use_hermetic_linux_sandbox, this allows us to see the interactive debug instructions like we'd see without it. Note that `EnterWorkingDirectory()` in `linux-sandbox` requires that the working directory is under the sandbox_root path, so we need to include `cwd=sandboxExecRoot()` when calling `describeCommand`. This is a stricter requirement than for SymlinkedSandboxedSpawn which was changed in bazelbuild#26448 more for UX reasons. Fixes bazelbuild#26580.
github-actions
bot
added
team-Local-Exec
|
@fmeum seems like this one might be right up your alley 😃 I'd also love to get this into 8.4.0. |
fmeum
approved these changes
Jul 19, 2025
|
@bazel-io fork 8.4.0 |
meisterT
approved these changes
Jul 21, 2025
meisterT
added
awaiting-PR-merge
github-actions
bot
removed
the
awaiting-PR-merge
iancha1992
pushed a commit
to iancha1992/bazel
that referenced
this pull request
Jul 23, 2025
When running with --experimental_use_hermetic_linux_sandbox, this allows us to see the interactive debug instructions like we'd see without it. Note that `EnterWorkingDirectory()` in `linux-sandbox` requires that the working directory is under the sandbox_root path, so we need to include `cwd=sandboxExecRoot()` when calling `describeCommand`. This is a stricter requirement than for SymlinkedSandboxedSpawn which was changed in bazelbuild#26448 more for UX reasons. Fixes bazelbuild#26580. Closes bazelbuild#26581. PiperOrigin-RevId: 786165593 Change-Id: Ib1a2dfccb7731691314d88d10e4c6a168977c875
iancha1992
pushed a commit
to iancha1992/bazel
that referenced
this pull request
Jul 23, 2025
When running with --experimental_use_hermetic_linux_sandbox, this allows us to see the interactive debug instructions like we'd see without it. Note that `EnterWorkingDirectory()` in `linux-sandbox` requires that the working directory is under the sandbox_root path, so we need to include `cwd=sandboxExecRoot()` when calling `describeCommand`. This is a stricter requirement than for SymlinkedSandboxedSpawn which was changed in bazelbuild#26448 more for UX reasons. Fixes bazelbuild#26580. Closes bazelbuild#26581. PiperOrigin-RevId: 786165593 Change-Id: Ib1a2dfccb7731691314d88d10e4c6a168977c875
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 24, 2025
…awn (#26619) When running with --experimental_use_hermetic_linux_sandbox, this allows us to see the interactive debug instructions like we'd see without it. Note that `EnterWorkingDirectory()` in `linux-sandbox` requires that the working directory is under the sandbox_root path, so we need to include `cwd=sandboxExecRoot()` when calling `describeCommand`. This is a stricter requirement than for SymlinkedSandboxedSpawn which was changed in #26448 more for UX reasons. Fixes #26580. Closes #26581. PiperOrigin-RevId: 786165593 Change-Id: Ib1a2dfccb7731691314d88d10e4c6a168977c875 Commit 289e385 --------- Co-authored-by: Wade Carpenter <wade@arista.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running with --experimental_use_hermetic_linux_sandbox, this allows us to see the interactive debug instructions like we'd see without it.
Note that
EnterWorkingDirectory()inlinux-sandboxrequires that the working directory is under the sandbox_root path, so we need to includecwd=sandboxExecRoot()when callingdescribeCommand. This is a stricter requirement than for SymlinkedSandboxedSpawn which was changed in #26448 more for UX reasons.Fixes #26580.