Skip to content

Parse correctly when PONG does not contain totcpport. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Parse correctly when PONG does not contain totcpport. #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions ethereum.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,11 +478,24 @@ function devp2p.dissector (tvb, pinfo, tree)
payloadtree:set_text("PING " .. string.toip(string.remove_quoted(toip)) .. ":" .. string.toport(string.remove_quoted(toport)))
elseif types[ptype] == "PONG" then
payloadtree:set_text(decodedvalue)
--message('PONG: ' .. decodedvalue)
local toip,toudpport,totcpport,replyhash, expiration = string.match(decodedvalue, '%[%[([^,]+), ([^,]+), ([^%]]+)%], ([^,]+), ([^%]]+)%]')
payloadtree:add("To:", string.toip(string.remove_quoted(toip)), string.toport(string.remove_quoted(toudpport)), string.toport(string.remove_quoted(totcpport)))
if toip == nil
then
-- Try it without the totcpport field.
toip,toudpport,replyhash, expiration = string.match(decodedvalue, '%[%[([^,]+), ([^%]]+)%], ([^,]+), ([^%]]+)%]')
end
toip_d = string.toip(string.remove_quoted(toip))
toudpport_d = string.toport(string.remove_quoted(toudpport))
totcpport_d = ''
if (totcpport ~= nil)
then
totcpport_d = string.toport(string.remove_quoted(totcpport))
end
payloadtree:add("To:", toip_d, toudpport_d, totcpport_d)
payloadtree:add("Hash:", string.remove_quoted(replyhash))
payloadtree:add("Expiration:", string.remove_quoted(expiration))
payloadtree:set_text("PONG " .. string.toip(string.remove_quoted(toip)) .. ":" .. string.toport(string.remove_quoted(toudpport)) .. "/" .. string.toport(string.remove_quoted(totcpport)))
payloadtree:set_text("PONG " .. toip_d .. ":" .. toudpport_d .. "/" .. totcpport_d)
elseif types[ptype] == "FindNode" then
payloadtree:set_text(decodedvalue)
local hash, expiration = string.match(decodedvalue, '%[([^,]+), ([^%]]+)%]')
Expand Down