Fix crash when moving nodes to the top #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Next step: need to fix the drag animation |
florianmari
changed the title
Contributor
|
Knowing why there’s a negative index would be nice, be otherwise that’s a cool guard 🙏 |
Contributor
Author
|
Yes totally I'm gonna invest deeper next week on that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not 100% sure about this one but the crash happened to me a lot, moving a node to the top lead to a crash because index is negative, just put the condition after the offset correction and seems to resolve the crash issue
Edit: Finally I have prevented bug with condition around the for to avoid any potential creation of other bugs, need to find later why this index can become negative, crash it not happening anymore