Skip to content

Conversation

@browniebroke
Copy link
Contributor

No description provided.

@browniebroke
Copy link
Contributor Author

As far as I can tell, the failures are from mypy, looks like the config crashes:

mypy.ini:2: error: Error importing plugin "mypy_django_plugin.main": cannot import name 'has_placeholder' from 'mypy.semanal_shared' (...python3.11/site-packages/mypy/semanal_shared.py)

It fails on older versions too, so maybe it's a 3rd party package not being pinned properly?

@browniebroke browniebroke mentioned this pull request Dec 13, 2023
@browniebroke
Copy link
Contributor Author

Gentle ping @ir4y - what do we need to get this merged?

@ir4y
Copy link
Member

ir4y commented Jul 22, 2024

Hi @browniebroke

Thank you for your contribution. Could you please fix the tests?
Once all of them are passed I will merge this changes.

Cheers,
Ilya

@ir4y
Copy link
Member

ir4y commented Jul 22, 2024

@browniebroke please feel free to include changes from #184 in this pull request and drop support for Django version that reached end of support period.

@browniebroke browniebroke changed the title Add official support for Django 5.0 and Python 3.12 Add official support for Django 5.0 and Python 3.12, drop support for Django <3.2 Jul 22, 2024
@codecov
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.23%. Comparing base (6b24fae) to head (f147adf).
Report is 15 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #183   +/-   ##
=======================================
  Coverage   98.23%   98.23%           
=======================================
  Files           3        3           
  Lines         227      227           
=======================================
  Hits          223      223           
  Misses          4        4           
Flag Coverage Δ
unittests 98.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@browniebroke
Copy link
Contributor Author

browniebroke commented Jul 22, 2024

@ir4y it's all passing now. Since I opened this, Django 3.2 reached EOL and DRF 3.15 was released. I could go a few steps further and drop support for Django <4.2 (which would mean dropping DRF <3.14) and add support for DRF 3.15, but that feels like a lot? Do you want to merge this one and do a release before moving on to the next set of fixes?

I'm trying to think of an upgrade path where users wouldn't have to upgrade too much at once, but actually I didn't really change anything in the code being released...

Edit: further changes that build on top of this #186 can be merged after if you want

@ruscoder ruscoder merged commit f147adf into beda-software:master Oct 29, 2024
@browniebroke browniebroke deleted the upgrade-django5.0-python3.12 branch October 29, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants