Skip to content

Refactor AuthProvider to throw original error #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Refactor AuthProvider to throw original error #278

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b5c3a4
Refactor AuthProvider to throw original error
qbantek May 17, 2023
b251567
Refactor AuthProvider.ts to handle multi-factor authentication
qbantek May 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/providers/AuthProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,14 @@ class AuthClient {
);
log('HandleAuthLogin: user sucessfully logged in', { user });
return user;
} catch (e) {
log('HandleAuthLogin: invalid credentials', { params });
throw new Error('Login error: invalid credentials');
} catch (e: any) {
if (e.code == 'auth/multi-factor-auth-required') {
log('HandleAuthLogin: second factor challenge required', { params });
throw e;
} else {
log('HandleAuthLogin: invalid credentials', { params });
throw new Error('Login error: invalid credentials');
}
}
} else {
return this.getUserLogin();
Expand Down