Fix typo in OSD description #4691
Conversation
WalkthroughCorrected a misspelled locale key across multiple language message files and updated the corresponding key usage in the OSD tab JS: "osdTextElementRemaningTimeEstimate" → "osdTextElementRemainingTimeEstimate" and "osdDescElementRemaningTimeEstimate" → "osdDescElementRemainingTimeEstimate". Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Potential hotspots to check:
Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
locales/en/messages.json (1)
6073-6077: Fix typo across all locales if addressing key naming (coordinated effort required).The misspelled keys
osdTextElementRemaningTimeEstimateandosdDescElementRemaningTimeEstimateare referenced insrc/js/tabs/osd.js(lines 1281–1282) and duplicated across all 32 locale files. Correcting this requires updates to:
src/js/tabs/osd.js(code references)- All locale files (locales/*/messages.json)
- Crowdin string mappings
Estimated ~66 locations total. Recommend as post-PR cleanup when coordinating with translation platform.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
locales/en/messages.json(1 hunks)
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: syahmizul
Repo: betaflight/betaflight-configurator PR: 4516
File: src/js/tabs/osd.js:3544-3559
Timestamp: 2025-06-14T13:43:10.231Z
Learning: In the Betaflight Configurator OSD positioning feature (src/js/tabs/osd.js), the elementWidth and elementHeight calculations use limits.maxX - limits.minX and limits.maxY - limits.minY without adding 1. While adding 1 would be mathematically correct for inclusive bounds, it causes visual centering issues where elements appear off-center. The current calculation produces better visual centering results, so the +1 correction should be avoided to maintain proper visual alignment.
Learnt from: haslinghuis
Repo: betaflight/betaflight-configurator PR: 4490
File: locales/en/messages.json:1534-1545
Timestamp: 2025-05-26T11:37:09.758Z
Learning: In the Betaflight Configurator repository, only English messages should be added directly to `locales/en/messages.json`; other language translations are handled via Crowdin automation and should not be manually updated in PRs.
📚 Learning: 2025-05-26T11:37:09.758Z
Learnt from: haslinghuis
Repo: betaflight/betaflight-configurator PR: 4490
File: locales/en/messages.json:1534-1545
Timestamp: 2025-05-26T11:37:09.758Z
Learning: In the Betaflight Configurator repository, only English messages should be added directly to `locales/en/messages.json`; other language translations are handled via Crowdin automation and should not be manually updated in PRs.
Applied to files:
locales/en/messages.json
📚 Learning: 2025-08-11T19:10:56.992Z
Learnt from: haslinghuis
Repo: betaflight/betaflight-configurator PR: 4567
File: locales/en/messages.json:7724-7728
Timestamp: 2025-08-11T19:10:56.992Z
Learning: In the Betaflight Configurator project, only English language entries are added directly to locales/en/messages.json. Translations for other languages are handled through an outsourced process and should not be suggested as part of code reviews.
Applied to files:
locales/en/messages.json
🔇 Additional comments (1)
locales/en/messages.json (1)
6077-6079: LGTM: typo fixed in description."remaning" → "remaining" reads correctly and matches existing style.
…RemaningTimeEstimate
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (20)
locales/ca/messages.json(1 hunks)locales/da/messages.json(1 hunks)locales/de/messages.json(1 hunks)locales/en/messages.json(1 hunks)locales/es/messages.json(1 hunks)locales/eu/messages.json(1 hunks)locales/fr/messages.json(1 hunks)locales/gl/messages.json(1 hunks)locales/it/messages.json(1 hunks)locales/ja/messages.json(1 hunks)locales/ko/messages.json(1 hunks)locales/nl/messages.json(1 hunks)locales/pl/messages.json(1 hunks)locales/pt/messages.json(1 hunks)locales/pt_BR/messages.json(1 hunks)locales/ru/messages.json(1 hunks)locales/uk/messages.json(1 hunks)locales/zh_CN/messages.json(1 hunks)locales/zh_TW/messages.json(1 hunks)src/js/tabs/osd.js(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- locales/pl/messages.json
🧰 Additional context used
🧠 Learnings (3)
📚 Learning: 2025-05-26T11:37:09.758Z
Learnt from: haslinghuis
Repo: betaflight/betaflight-configurator PR: 4490
File: locales/en/messages.json:1534-1545
Timestamp: 2025-05-26T11:37:09.758Z
Learning: In the Betaflight Configurator repository, only English messages should be added directly to `locales/en/messages.json`; other language translations are handled via Crowdin automation and should not be manually updated in PRs.
Applied to files:
locales/zh_CN/messages.jsonlocales/en/messages.json
📚 Learning: 2025-08-11T19:10:56.992Z
Learnt from: haslinghuis
Repo: betaflight/betaflight-configurator PR: 4567
File: locales/en/messages.json:7724-7728
Timestamp: 2025-08-11T19:10:56.992Z
Learning: In the Betaflight Configurator project, only English language entries are added directly to locales/en/messages.json. Translations for other languages are handled through an outsourced process and should not be suggested as part of code reviews.
Applied to files:
locales/en/messages.json
📚 Learning: 2025-06-14T13:43:10.231Z
Learnt from: syahmizul
Repo: betaflight/betaflight-configurator PR: 4516
File: src/js/tabs/osd.js:3544-3559
Timestamp: 2025-06-14T13:43:10.231Z
Learning: In the Betaflight Configurator OSD positioning feature (src/js/tabs/osd.js), the elementWidth and elementHeight calculations use limits.maxX - limits.minX and limits.maxY - limits.minY without adding 1. While adding 1 would be mathematically correct for inclusive bounds, it causes visual centering issues where elements appear off-center. The current calculation produces better visual centering results, so the +1 correction should be avoided to maintain proper visual alignment.
Applied to files:
locales/en/messages.json
🔇 Additional comments (18)
locales/da/messages.json (1)
5988-5994: Verification complete — all locales updated consistently.Both verification checks passed:
- ✓ No stale "RemaningTimeEstimate" (typo) keys remain
- ✓ All 20 locale files contain the corrected
osdTextElementRemainingTimeEstimateandosdDescElementRemainingTimeEstimatekeysThe rename is complete and consistent across the codebase.
locales/gl/messages.json (1)
5199-5205: Verification complete—rename is consistent and properly migrated.Script confirmed:
- No old typoed keys remain in the codebase
- New keys present across all 20 locale files
- UI code at
src/js/tabs/osd.js:1281–1282correctly references the new keysThe typo fix is complete and safely applied without stragglers.
locales/ja/messages.json (1)
5981-5986: Typo fix verified and completeAll verification checks passed: no stale misspelled keys remain, corrected keys are present in all locale files, and no app code references the old misspelled keys. The change is consistent across the codebase.
locales/pt_BR/messages.json (1)
5376-5381: OSD key spelling correction verified.Confirmed: corrected keys
osdTextElementRemainingTimeEstimateandosdDescElementRemainingTimeEstimateare present in the locale file (lines 5376, 5380) and actively used insrc/js/tabs/osd.js(lines 1281–1282). No stale references to the old misspelled keys remain.src/js/tabs/osd.js (1)
1281-1282: LGTM! Typo correction applied correctly.The spelling fix from "Remaning" to "Remaining" is correct, and both the text and description locale keys have been updated consistently.
locales/it/messages.json (1)
5984-5990: Verification complete—all checks passed. Approved.
- ✓ No stale references to old "Remaning" keys
- ✓ Italian locale contains both osdTextElementRemainingTimeEstimate and osdDescElementRemainingTimeEstimate
- ✓ All locales have parity on both new keys
locales/pt/messages.json (1)
5984-5989: Typo fix and key rename verified—no lingering old keys found.The corrected keys
osdTextElementRemainingTimeEstimateandosdDescElementRemainingTimeEstimateare properly defined in the locale file and consistently referenced insrc/js/tabs/osd.js(lines 1281–1282). No traces of the old misspelled variant remain.locales/fr/messages.json (1)
4576-4582: Verification confirms all changes are correct and completeThe script confirms:
- No old misspelled keys (
Remaning) remain anywhere- New keys (
Remaining) are properly referenced insrc/js/tabs/osd.js(lines 1281–1282)- All locale files have been consistently updated with the corrected spelling
Code is ready to merge.
locales/nl/messages.json (1)
3858-3864: Typo correction properly applied.The OSD description keys have been correctly updated from the misspelled "Remaning" to the correct "Remaining". The message content is preserved unchanged, and the changes align with the coordinated corrections across other locale files mentioned in the enriched summary.
locales/ko/messages.json (1)
5953-5959: LGTM — typo fixed and keys fully synchronized across all locales and code.Verification confirms:
- No lingering "Remaning…" spellings remain anywhere in the repo
- New corrected keys present in all 16 locale files (en, de, es, fr, it, ja, nl, pl, pt, pt_BR, ru, uk, zh_CN, zh_TW, ca, da, eu, gl, ko)
- Code actively references the new keys at
src/js/tabs/osd.js:1281–1282locales/eu/messages.json (1)
3652-3658: Correct typo fix in OSD element keys.The JSON keys have been correctly updated from
osdTextElementRemaningTimeEstimateandosdDescElementRemaningTimeEstimateto their properly spelled counterparts with "Remaining" (adding the missing 'i'). The message values remain unchanged. This fix is consistent with the coordinated typo corrections across all locale files as stated in the PR objectives.locales/uk/messages.json (1)
5984-5990: Typo fix verified and complete.All verification checks passed:
- No lingering old keys ("RemaningTimeEstimate") found anywhere
- All 30 locale files contain the corrected keys ("RemainingTimeEstimate")
- Code references in
src/js/tabs/osd.js(lines 1281-1282) already use the corrected key names- No stale references remain
locales/zh_TW/messages.json (1)
3579-3585: Typo fix: correct JSON key names for OSD timer element.The misspelled keys
osdTextElementRemaningTimeEstimateandosdDescElementRemaningTimeEstimatehave been correctly renamed toosdTextElementRemainingTimeEstimateandosdDescElementRemainingTimeEstimate(fixing "Remaning" → "Remaining"). The message values remain unchanged, which is appropriate for a key-rename operation.Note: The PR summary indicates this change spans multiple language message files. This review only covers the
zh_TWlocalization file provided; please ensure the same typo corrections have been applied consistently across all other language files (e.g.,en,de,fr, etc.).locales/de/messages.json (1)
5499-5505: Typo fix verified across all locales and source code.No stale misspelled key references found. Both corrected keys
osdTextElementRemainingTimeEstimateandosdDescElementRemainingTimeEstimateare present in all 22 locale files and correctly referenced insrc/js/tabs/osd.js:1281-1282. Change is safe to merge.locales/ca/messages.json (1)
5992-5995: Key names are already correctly spelled; verification scripts target non-existent issuesThe search results confirm that
osdTextElementRemainingTimeEstimateandosdDescElementRemainingTimeEstimateare correctly spelled across all locale files (ca, es, en, fr, de, ja, pt, etc.) and insrc/js/tabs/osd.js(lines 1281-1282). No misspelled variants exist to verify against.However, there is a genuine typo in the Catalan translation: line 5998 contains "Temps estimat restant de volt" where "volt" should be "vol".
Likely an incorrect or invalid review comment.
locales/en/messages.json (1)
6073-6076: No issues found; review comment is incorrect.The verification shows that all references to these i18n keys—both in
src/js/tabs/osd.js(lines 1281–1282) and across all 19 locale files—already use the correct spellingosdTextElementRemainingTimeEstimateandosdDescElementRemainingTimeEstimate(with "Remaining"). There is no key rename happening in this PR, and no "Remaning" (typo) variant exists anywhere in the codebase. The original review comment's concern about breaking translations due to a key rename is unfounded.Likely an incorrect or invalid review comment.
locales/ru/messages.json (1)
5882-5888: Typo fix verified across all locales; no stale references remain.Script confirms zero occurrences of old "Remaning" keys and consistent presence of corrected "Remaining" keys across all 30+ locale files, including the Russian locale under review. Changes are complete and safe to merge.
locales/es/messages.json (1)
5949-5955: Typo fix verified—all locales updated consistently, no stale references remain.Confirmed:
- Old misspelled key (RemaningTimeEstimate) completely removed
- New correct keys (osdTextElementRemainingTimeEstimate, osdDescElementRemainingTimeEstimate) present in all 20 locale files
- Source code in src/js/tabs/osd.js correctly references the new keys
- Spanish translations are grammatically sound
|
|
Preview URL: https://pr4691.betaflight-app-preview.pages.dev |
|
Thank you for the nice first PR! 🙂 |
3 participants
Fixes a small typo in the english OSD description.
Summary by CodeRabbit