-
Notifications
You must be signed in to change notification settings - Fork 5.8k
BIP 433: Add P2A BIP #1982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
BIP 433: Add P2A BIP #1982
Conversation
jonatack
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick first pass.
|
|
||
| ====Backward Compatibility==== | ||
|
|
||
| Creation of P2A outputs has been considered standard since the deployment of Segwit softfork on the network. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe link here to the SegWit BIP section making them standard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the BIPs aren't standardness BIPs, so I'm not sure that helps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Roasbeef
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this. Nearly done with an implementation for btcsuite.
3451560 to
9ed387c
Compare
murchandamus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good already. I got a bag of nits for you.
|
|
||
| ====Backward Compatibility==== | ||
|
|
||
| Creation of P2A outputs has been considered standard since the deployment of Segwit softfork on the network. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
This BIP has been assigned number 433! (can update the readme in the PR to reflect assignment) |
|
Please add an entry to the table in the README.md for your BIP, add the number to the preamble, and update the “Created” header to 2025-12-08. |
7ab1a16 to
3afec38
Compare
|
Thanks for the review and number! |
3afec38 to
ab9bc69
Compare
murchandamus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me. ACK ab9bc69
For interoperability with other schemes, it behooves me to write a BIP for this output type. It's already standard to spend in well over half the network.
h/t roasbeef for bothering me about this repeatedly