[PM-19152] Archive in Web #16686
[PM-19152] Archive in Web #16686
Conversation
…hanges, and item more option changes
|
New Issues (1)Checkmarx found the following issues in this Pull Request
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #16686 +/- ##
==========================================
- Coverage 38.79% 38.76% -0.04%
==========================================
Files 3394 3394
Lines 96439 96525 +86
Branches 14465 14484 +19
==========================================
+ Hits 37418 37421 +3
- Misses 57389 57470 +81
- Partials 1632 1634 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| "archiveItemConfirmDesc": { | ||
| "message": "Archived items are excluded from general search results and autofill suggestions. Are you sure you want to archive this item?" | ||
| }, |
There was a problem hiding this comment.
🎨 There should probably be a bulk version of this statement too
"archiveItemsConfirmDesc": {
"message": "Archived items are excluded from general search results and autofill suggestions. Are you sure you want to archive these items?"
},
There was a problem hiding this comment.
good call, going to do the same for the title
| this.toastService.showToast({ | ||
| variant: "success", | ||
| message: this.i18nService.t("itemUnarchived"), | ||
| }); |
There was a problem hiding this comment.
❓ is a this.refresh(); missing here?
| this.toastService.showToast({ | ||
| variant: "success", | ||
| message: this.i18nService.t("itemWasSentToArchive"), | ||
| }); |
There was a problem hiding this comment.
❓ is a this.refresh(); missing here?
| </button> | ||
| <button | ||
| bitMenuItem | ||
| *ngIf="showAssignToCollections" |
There was a problem hiding this comment.
❓ Should the showAssignToCollections variable be updated to exclude archived items? I assume a user shouldn't be able to move an item to an organization if it is archived.
There was a problem hiding this comment.
ah yeah good call here too. Will add archive check for showAssignToCollections
There was a problem hiding this comment.
I'm going to put this question here because it is related to filters but not the code changes here. Should it be possible to select an organization and archive filter? This will always result in the empty state as organization ciphers cannot be archived but also could imply that the user can have archived org ciphers.
There was a problem hiding this comment.
This is a good point. Will bubble this question up. If any further implementation I'll add it in another ticket.
|
🎟️ Tracking
PM-19152 Web Archive Vault and Filter
PM-25188 Web Archive Vault More Options Menu
PM-25189 Web Archive Bulk Options
📔 Objective
Adding the Archive features to the web vault
Unarchive, Deletein more options menuCloneOption will not appear in archive vault ifEnforce Org Data Ownershippolicy is onNote: Unarchive Icon is not ready yet. If it isn't ready by PR merge I'll make a new ticket for it later
📸 Screen Recording
PM-19152.PM-25188.PM-25189.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes