-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[PM-24032] - adds a new upgrade plan button to side nav #16687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This should compile just the library files and not its dependency files which was making it error
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #16687 +/- ##
==========================================
+ Coverage 38.94% 38.97% +0.02%
==========================================
Files 3437 3439 +2
Lines 97510 97585 +75
Branches 14666 14671 +5
==========================================
+ Hits 37977 38033 +56
- Misses 57874 57893 +19
Partials 1659 1659 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, awesome work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Vault changes are minimal
# Conflicts: # apps/web/src/app/billing/individual/upgrade/unified-upgrade-dialog/unified-upgrade-dialog.component.html
b283de7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of thoughts! Looking at the Chromatic diffs, I see that the Navigation Product Switcher: Only PM story has a diff that looks unexpected to me.
...g/individual/upgrade/upgrade-nav-button/upgrade-nav-button/upgrade-nav-button.component.html
Outdated
Show resolved
Hide resolved
...g/individual/upgrade/upgrade-nav-button/upgrade-nav-button/upgrade-nav-button.component.html
Show resolved
Hide resolved
@vleague2 I think you are referring to the fact the "PM" product is not showing any more in the switcher. I can confirm this is expected so I approved the Chromatic PR. (We removed it since it is duplicative of the logo when it is on its own. This will also allow the "Upgrade" button to stand out a bit more). |
|




🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-24032
📔 Objective
Adds a new upgrade plan button to the side nav of web vault. The button opens the new upgrade dialog. The upgrade dialog includes new customization including a new title for this flow as well as an info message on the payment screen if the user chose the families plan but has a free org already.
This PR also includes a change requested by design/product to not show the product switcher in the left nav if the user only has access to one product.
Finally, this required adding a new icon to the icon font so those changes are included and team UIF are attached to this PR to review.
📸 Screenshots
Here are several screenshots showing different states of the side nav, depending on who is logged in. Refer to the figma here to compare designs to the screenshots and see all of the tested scenarios available.
Free user with no org:

Free user with free org:

Free user with free org dark mode:

Member of paid org with secrets manager access:

Member of paid org without secrets manager access:

Owner of paid org with secrets manager:

Premium user with no org:

Screenshot of the edge case families with free org info message:

Here is a video showing the hover and focus states:
https://github.com/user-attachments/assets/aa782f03-d1ac-4d39-bc75-e6183ca4d1f4
Here is a video showing the process of signing up for premium:
https://github.com/user-attachments/assets/0dec99d1-b94e-4553-bbcc-f461371e7eb2
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes