Skip to content

Conversation

BTreston
Copy link
Contributor

@BTreston BTreston commented Oct 2, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-23133

📔 Objective

Major refactor of the members component. The goal of this is to rip out as much of the business logic around members as possible into smaller more manageable classes (especially the billing logic).

New Services Created (with tests):

  • billing-constraint.service - Handles billing and payment-related constraints and logic
  • member-actions.service - Manages member operations (remove, revoke, restore, reinvite, confirm)
  • member-dialog-manager.service - Centralizes dialog management logic
  • organization-members.service - Handles fetching and processing organization users

Yet to be done in a follow up: removing the base class and inheritance.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@BTreston BTreston requested a review from a team as a code owner October 2, 2025 15:23
@BTreston BTreston requested a review from r-tome October 2, 2025 15:23
Copy link

sonarqubecloud bot commented Oct 2, 2025

Copy link
Contributor

github-actions bot commented Oct 2, 2025

Logo
Checkmarx One – Scan Summary & Detailsc69c73ff-4404-41c9-982a-7ced478867d4

Great job! No new security vulnerabilities introduced in this pull request

Copy link
Contributor

@r-tome r-tome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. Thanks for writing all those tests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants