Skip to content

Conversation

fer
Copy link

@fer fer commented Oct 3, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-26487

📔 Objective

  • Updated MemberAccessReportView - Added optional userId? and avatarColor? fields
  • Updated MemberAccessResponse - Added optional userId? and avatarColor? fields with proper API parsing
  • Updated MemberAccessReportService - Populates the new fields from API data with null-safety
  • Updated HTML Template - Added [id] and [color] bindings to the avatar, with fallback to email if name is missing

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@fer fer requested a review from a team as a code owner October 3, 2025 16:06
@CLAassistant
Copy link

CLAassistant commented Oct 3, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@bitwarden-bot
Copy link

Thank you for your contribution! We've added this to our internal tracking system for review.
ID: PM-26501
Link: https://bitwarden.atlassian.net/browse/PM-26501

Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process.

@bitwarden-bot bitwarden-bot added needs-qa Marks a PR as requiring QA approval community-pr and removed needs-qa Marks a PR as requiring QA approval labels Oct 3, 2025
@fer fer removed the community-pr label Oct 3, 2025
@fer fer changed the title adding userId and avatarColor where missing in member access report component [PM-26487] adding userId and avatarColor where missing in member access report component Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants