-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[BEEEP] Add println clippy lints for desktop_native
.
#16761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
New Issues (18)Checkmarx found the following issues in this Pull Request
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16761 +/- ##
==========================================
- Coverage 38.82% 38.76% -0.07%
==========================================
Files 3405 3406 +1
Lines 96616 96688 +72
Branches 14512 14533 +21
==========================================
- Hits 37508 37477 -31
- Misses 57470 57573 +103
Partials 1638 1638 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-26091
📔 Objective
As follow-up to #16321 , disable
println
andeprintln
. This check is run in CI. Local debugging using printlns is unaffected.**NOTE: this PR will fail due to the lint until the following PRs are merged:
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes