Skip to content

feat: allowed admin to modify/delete testcase #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: allowed admin to modify/delete testcase #21

wants to merge 1 commit into from

Conversation

trinhdvt
Copy link
Member

@trinhdvt trinhdvt commented Sep 14, 2022 •
edited
Loading

Fixes bkdnOJv2/bkdnOJ-v2#10

Changelog:

  • Modified Problem's test case detail page
  • Created test case edit page
  • Installed useSWR for data fetching

Screenshots:

  • Problem's test case detail page
    image
  • Test case edit page (Click edit on any test in page above)
    image

Preview link: bkdn-oj-git-is10-trinhdvt.vercel.app

trinhdvt
trinhdvt commented Sep 17, 2022
View reviewed changes
Copy link
Member Author

@trinhdvt trinhdvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review UI đi bro @nvatuan, hiu

@trinhdvt trinhdvt marked this pull request as ready for review September 17, 2022 10:39
@nvatuan
Copy link
Member

nvatuan commented Sep 17, 2022 •
edited
Loading

  • Mấy ô input bro chỉnh kiểu này giúp tôi nha, giống y thế này là ngon, font kiểu monospace ấy
    image
  • Dời label Delete sang phải cùng giúp nha
  • Và ở màn hình detail chỉnh cái label này lại ik:
    image

trinhdvt
trinhdvt commented Sep 18, 2022
View reviewed changes
Copy link
Member Author

@trinhdvt trinhdvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sửa lại rồi nha bro @nvatuan

Preview link: bkdn-oj-git-is10-trinhdvt.vercel.app

@trinhdvt trinhdvt mentioned this pull request Sep 18, 2022
Open
@nvatuan nvatuan force-pushed the main branch 2 times, most recently from 054cb1c to 1a07970 Compare September 30, 2022 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURE] Cần cơ chế thay đổi/thêm Testcase thông qua WebAdmin

2 participants

@trinhdvt @nvatuan