retry failed scass signature scan #1496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ption-test Dev/dterry/scass exception test
dterrybd
requested review from
shantyk,
devmehtabd,
andrian-sevastyanov and
zahidblackduck
| spyRunner.runSignatureScannerOnline(detectRunUuid, projectNameVersion, dockerTargetData, scanIdsToWaitFor, | ||
| gson); | ||
|
|
||
| verify(spyRunner, times(2)).executeScan(any(), any(), any(), any(), any(), anyBoolean(), anyBoolean()); |
There was a problem hiding this comment.
Maybe a similar test that doesn't throw exception and verifies that the call is made only once is worthwhile in addition to this one?
andrian-sevastyanov
approved these changes
Jul 31, 2025
devmehtabd
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user has not allowed the SCASS IPs we want to retry the SCASS scan using the previous approach. I originally tried pushing down a lot of data to do this but it's easier, and I think cleaner, to just bubble back up to the start and being a new scan without the --scass-scan argument.