Add config options to streamline with k8s standards #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many K8s inegrations are controlled via annotations on the resources e.g Prometheus discovery or load balancer behavior, making them configurable adds more flexibility to the deployment. Also the fields in the TLS secret are by default tls.crt and tls.key making this configurable increases integration with tools like cert-manager
|
This is similar, in some respect, to #74. A more flexible configuration model to enable operators to define annotations for external tools or people. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many K8s inegrations are controlled via annotations on the resources
e.g Prometheus discovery or load balancer behavior, making them
configurable adds more flexibility to the deployment.
Also the fields in the TLS secret are by default tls.crt and tls.key
making this configurable increases integration with tools like
cert-manager