Skip to content

fix: use stability window for slot threshold #985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+1,555 −38
Open

fix: use stability window for slot threshold #985

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 9 additions & 17 deletions ledger/chainsync.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ import (
"encoding/hex"
"errors"
"fmt"
"math/big"
"slices"
"time"

Expand All @@ -36,9 +35,8 @@ const (
// This prevents us exceeding the configured recv queue size in the block-fetch protocol
blockfetchBatchSize = 500

// TODO: calculate from protocol params
// Number of slots from upstream tip to stop doing blockfetch batches
blockfetchBatchSlotThreshold = 2500 * 20
// Default/fallback slot threshold for blockfetch batches
blockfetchBatchSlotThresholdDefault = 2500 * 20

// Timeout for updates on a blockfetch operation. This is based on a 2s BatchStart
// and a 2s Block timeout for blockfetch
Expand Down Expand Up @@ -141,8 +139,10 @@ func (ls *LedgerState) handleEventChainsyncBlockHeader(e ChainsyncEvent) error {
}
// Wait for additional block headers before fetching block bodies if we're
// far enough out from upstream tip
// Use security window as slot threshold if available
slotThreshold := ls.calculateStabilityWindow()
if e.Point.Slot < e.Tip.Point.Slot &&
(e.Tip.Point.Slot-e.Point.Slot > blockfetchBatchSlotThreshold) &&
(e.Tip.Point.Slot-e.Point.Slot > slotThreshold) &&
(headerCount+1) < allowedHeaderCount {
return nil
}
Expand Down Expand Up @@ -258,6 +258,9 @@ func (ls *LedgerState) calculateEpochNonce(
}
// Use Shelley genesis hash for initial epoch nonce
if len(ls.currentEpoch.Nonce) == 0 {
if ls.config.CardanoNodeConfig.ShelleyGenesisHash == "" {
return nil, errors.New("could not get Shelley genesis hash")
}
genesisHashBytes, err := hex.DecodeString(
ls.config.CardanoNodeConfig.ShelleyGenesisHash,
)
Expand All @@ -267,18 +270,7 @@ func (ls *LedgerState) calculateEpochNonce(
return genesisHashBytes, nil
}
// Calculate stability window
byronGenesis := ls.config.CardanoNodeConfig.ByronGenesis()
shelleyGenesis := ls.config.CardanoNodeConfig.ShelleyGenesis()
if byronGenesis == nil || shelleyGenesis == nil {
return nil, errors.New("could not get genesis config")
}
stabilityWindow := new(big.Rat).Quo(
big.NewRat(
int64(3*byronGenesis.ProtocolConsts.K),
1,
),
shelleyGenesis.ActiveSlotsCoeff.Rat,
).Num().Uint64()
stabilityWindow := ls.calculateStabilityWindow()
var stabilityWindowStartSlot uint64
if epochStartSlot > stabilityWindow {
stabilityWindowStartSlot = epochStartSlot - stabilityWindow
Expand Down
Loading
Loading