Feat: Send userAgent with client identity
#62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pniedzielski
force-pushed
the
feat/user-agent
branch
3 times, most recently
from
eafff7b to
3b3e8be
Compare
CI is failing because of the deprecated version of `actions/upload-artifact`. According to the documentation linked in https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/, our usage of this action is safe to just bump the version number from `v3` to `v4`. Signed-off-by: Patrick M. Niedzielski <pniedzielski@bloomberg.net>
pniedzielski
force-pushed
the
feat/user-agent
branch
5 times, most recently
from
498bc90 to
24fd2aa
Compare
This patch teaches session negotiation to send a user agent of the form "com.bloomberg.bmq(javaXX.YY.ZZ):AA.BB.CC", where "XX.YY.ZZ" is the version of Java this SDK is running on, and "AA.BB.CC" is the SDK version. It additionally sets the user agent to in the `PlainConsumerIT` and `PlainProducerIT` integration test clients to different strings. These clients are not simple users of this SDK, and construct the sockets they communicate on directly. It is thus useful to distinguish them on the broker from normal users of the SDK. Signed-off-by: Patrick M. Niedzielski <pniedzielski@bloomberg.net>
This patch exposes an option in `SessionOptions` that a user can set, which will be prefixed to the beginning of the user agent sent to the broker during session negotiation. This prefix does not need to be set, but if it is, it must consist only of printable ASCII characters and must be less than 128 characters long. Signed-off-by: Patrick M. Niedzielski <pniedzielski@bloomberg.net>
pniedzielski
force-pushed
the
feat/user-agent
branch
6 times, most recently
from
3f9e63f to
c697852
Compare
Signed-off-by: Patrick M. Niedzielski <pniedzielski@bloomberg.net>
Signed-off-by: Patrick M. Niedzielski <pniedzielski@bloomberg.net>
pniedzielski
force-pushed
the
feat/user-agent
branch
from
c697852 to
3e77a2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bloomberg/blazingmq#1036